Skip to content

Fix Check Pull Request CI Status job - #8809

Merged
cbeauchesne merged 3 commits into
masterfrom
cbeauchesne/fix-all-green
May 13, 2025
Merged

Fix Check Pull Request CI Status job#8809
cbeauchesne merged 3 commits into
masterfrom
cbeauchesne/fix-all-green

Conversation

@cbeauchesne

@cbeauchesne cbeauchesne commented May 13, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

@pr-commenter

pr-commenter Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-13T09:27:00 2025-05-13T09:34:48
git_branch master cbeauchesne/fix-all-green
git_commit_date 1747122031 1747127693
git_commit_sha 25acb15 396b575
release_version 1.50.0-SNAPSHOT~25acb15350 1.50.0-SNAPSHOT~396b575923
start_time 2025-05-13T09:26:45 2025-05-13T09:34:34
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747129288 1747129288
ci_job_id 935238158 935238158
ci_pipeline_id 64907491 64907491
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-px6-mzwm-project-304-concurrent-1-v0p2dlie 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-px6-mzwm-project-304-concurrent-1-v0p2dlie 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~396b575923, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.379 ms) : 1360, 1399
.   : milestone, 1379,
appsec (1.755 ms) : 1731, 1780
.   : milestone, 1755,
appsec_no_iast (1.734 ms) : 1710, 1757
.   : milestone, 1734,
code_origins (1.692 ms) : 1665, 1719
.   : milestone, 1692,
iast (1.534 ms) : 1509, 1558
.   : milestone, 1534,
profiling (1.53 ms) : 1507, 1553
.   : milestone, 1530,
tracing (1.505 ms) : 1480, 1530
.   : milestone, 1505,
section candidate
no_agent (1.375 ms) : 1355, 1396
.   : milestone, 1375,
appsec (1.747 ms) : 1724, 1770
.   : milestone, 1747,
appsec_no_iast (1.739 ms) : 1715, 1763
.   : milestone, 1739,
code_origins (1.696 ms) : 1669, 1723
.   : milestone, 1696,
iast (1.539 ms) : 1515, 1564
.   : milestone, 1539,
profiling (1.542 ms) : 1519, 1566
.   : milestone, 1542,
tracing (1.499 ms) : 1477, 1522
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.379 ms [1.36 ms, 1.399 ms] -
appsec 1.755 ms [1.731 ms, 1.78 ms] 375.586 µs (27.2%)
appsec_no_iast 1.734 ms [1.71 ms, 1.757 ms] 354.184 µs (25.7%)
code_origins 1.692 ms [1.665 ms, 1.719 ms] 312.386 µs (22.6%)
iast 1.534 ms [1.509 ms, 1.558 ms] 154.02 µs (11.2%)
profiling 1.53 ms [1.507 ms, 1.553 ms] 150.595 µs (10.9%)
tracing 1.505 ms [1.48 ms, 1.53 ms] 125.161 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.375 ms [1.355 ms, 1.396 ms] -
appsec 1.747 ms [1.724 ms, 1.77 ms] 371.744 µs (27.0%)
appsec_no_iast 1.739 ms [1.715 ms, 1.763 ms] 363.697 µs (26.4%)
code_origins 1.696 ms [1.669 ms, 1.723 ms] 320.928 µs (23.3%)
iast 1.539 ms [1.515 ms, 1.564 ms] 164.297 µs (11.9%)
profiling 1.542 ms [1.519 ms, 1.566 ms] 167.113 µs (12.2%)
tracing 1.499 ms [1.477 ms, 1.522 ms] 124.306 µs (9.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~396b575923, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (389.106 µs) : 369, 409
.   : milestone, 389,
iast (525.083 µs) : 501, 549
.   : milestone, 525,
iast_FULL (739.576 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (566.291 µs) : 545, 588
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (535.504 µs) : 513, 558
.   : milestone, 536,
iast_INACTIVE (477.783 µs) : 455, 500
.   : milestone, 478,
iast_TELEMETRY_OFF (525.774 µs) : 502, 550
.   : milestone, 526,
tracing (467.12 µs) : 445, 489
.   : milestone, 467,
section candidate
no_agent (387.808 µs) : 367, 408
.   : milestone, 388,
iast (532.053 µs) : 509, 555
.   : milestone, 532,
iast_FULL (743.573 µs) : 721, 766
.   : milestone, 744,
iast_GLOBAL (566.785 µs) : 545, 589
.   : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (537.058 µs) : 514, 560
.   : milestone, 537,
iast_INACTIVE (477.377 µs) : 454, 501
.   : milestone, 477,
iast_TELEMETRY_OFF (509.127 µs) : 486, 532
.   : milestone, 509,
tracing (468.924 µs) : 447, 491
.   : milestone, 469,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 389.106 µs [368.941 µs, 409.272 µs] -
iast 525.083 µs [501.292 µs, 548.873 µs] 135.976 µs (34.9%)
iast_FULL 739.576 µs [717.56 µs, 761.592 µs] 350.47 µs (90.1%)
iast_GLOBAL 566.291 µs [544.585 µs, 587.998 µs] 177.185 µs (45.5%)
iast_HARDCODED_SECRET_DISABLED 535.504 µs [512.548 µs, 558.46 µs] 146.398 µs (37.6%)
iast_INACTIVE 477.783 µs [455.391 µs, 500.175 µs] 88.677 µs (22.8%)
iast_TELEMETRY_OFF 525.774 µs [502.012 µs, 549.536 µs] 136.668 µs (35.1%)
tracing 467.12 µs [444.828 µs, 489.413 µs] 78.014 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 387.808 µs [367.494 µs, 408.122 µs] -
iast 532.053 µs [508.833 µs, 555.272 µs] 144.245 µs (37.2%)
iast_FULL 743.573 µs [721.495 µs, 765.65 µs] 355.764 µs (91.7%)
iast_GLOBAL 566.785 µs [545.059 µs, 588.51 µs] 178.976 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED 537.058 µs [514.114 µs, 560.002 µs] 149.25 µs (38.5%)
iast_INACTIVE 477.377 µs [454.095 µs, 500.658 µs] 89.569 µs (23.1%)
iast_TELEMETRY_OFF 509.127 µs [486.044 µs, 532.211 µs] 121.319 µs (31.3%)
tracing 468.924 µs [446.799 µs, 491.049 µs] 81.116 µs (20.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cbeauchesne/fix-all-green
git_commit_date 1747122031 1747127693
git_commit_sha 25acb15 396b575
release_version 1.50.0-SNAPSHOT~25acb15350 1.50.0-SNAPSHOT~396b575923
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747129796 1747129796
ci_job_id 935238160 935238160
ci_pipeline_id 64907491 64907491
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hcefm8tt-project-304-concurrent-0-1nl38jfw 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hcefm8tt-project-304-concurrent-0-1nl38jfw 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~396b575923, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
appsec (15.021 s) : 15021000, 15021000
.   : milestone, 15021000,
iast (18.75 s) : 18750000, 18750000
.   : milestone, 18750000,
iast_GLOBAL (18.13 s) : 18130000, 18130000
.   : milestone, 18130000,
profiling (14.9 s) : 14900000, 14900000
.   : milestone, 14900000,
tracing (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
section candidate
no_agent (14.94 s) : 14940000, 14940000
.   : milestone, 14940000,
appsec (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
iast (18.779 s) : 18779000, 18779000
.   : milestone, 18779000,
iast_GLOBAL (18.051 s) : 18051000, 18051000
.   : milestone, 18051000,
profiling (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
tracing (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.253 s [15.253 s, 15.253 s] -
appsec 15.021 s [15.021 s, 15.021 s] -232.0 ms (-1.5%)
iast 18.75 s [18.75 s, 18.75 s] 3.497 s (22.9%)
iast_GLOBAL 18.13 s [18.13 s, 18.13 s] 2.877 s (18.9%)
profiling 14.9 s [14.9 s, 14.9 s] -353.0 ms (-2.3%)
tracing 14.845 s [14.845 s, 14.845 s] -408.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.94 s [14.94 s, 14.94 s] -
appsec 15.04 s [15.04 s, 15.04 s] 100.0 ms (0.7%)
iast 18.779 s [18.779 s, 18.779 s] 3.839 s (25.7%)
iast_GLOBAL 18.051 s [18.051 s, 18.051 s] 3.111 s (20.8%)
profiling 15.071 s [15.071 s, 15.071 s] 131.0 ms (0.9%)
tracing 14.997 s [14.997 s, 14.997 s] 57.0 ms (0.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~396b575923, baseline=1.50.0-SNAPSHOT~25acb15350
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.42 ms) : 2371, 2469
.   : milestone, 2420,
iast (2.198 ms) : 2136, 2260
.   : milestone, 2198,
iast_GLOBAL (2.248 ms) : 2185, 2311
.   : milestone, 2248,
profiling (2.054 ms) : 2004, 2104
.   : milestone, 2054,
tracing (2.021 ms) : 1973, 2069
.   : milestone, 2021,
section candidate
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.415 ms) : 2366, 2464
.   : milestone, 2415,
iast (2.199 ms) : 2137, 2260
.   : milestone, 2199,
iast_GLOBAL (2.246 ms) : 2183, 2309
.   : milestone, 2246,
profiling (2.045 ms) : 1996, 2095
.   : milestone, 2045,
tracing (2.015 ms) : 1967, 2063
.   : milestone, 2015,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 2.42 ms [2.371 ms, 2.469 ms] 938.143 µs (63.3%)
iast 2.198 ms [2.136 ms, 2.26 ms] 716.353 µs (48.3%)
iast_GLOBAL 2.248 ms [2.185 ms, 2.311 ms] 766.243 µs (51.7%)
profiling 2.054 ms [2.004 ms, 2.104 ms] 572.44 µs (38.6%)
tracing 2.021 ms [1.973 ms, 2.069 ms] 538.93 µs (36.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 2.415 ms [2.366 ms, 2.464 ms] 933.162 µs (63.0%)
iast 2.199 ms [2.137 ms, 2.26 ms] 716.639 µs (48.4%)
iast_GLOBAL 2.246 ms [2.183 ms, 2.309 ms] 764.034 µs (51.6%)
profiling 2.045 ms [1.996 ms, 2.095 ms] 563.413 µs (38.0%)
tracing 2.015 ms [1.967 ms, 2.063 ms] 532.743 µs (35.9%)

bric3
bric3 approved these changes May 13, 2025
View reviewed changes

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe drop in the explanation why the name has to be the same as the job id.

Otherwise LGTM

@cbeauchesne

cbeauchesne commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

done in 396b575

Though, I added a link to the full explanation here : https://github.com/DataDog/ensure-ci-success/blob/main/docs/limitations.md#do-not-set-a-name-to-the-job-shipping-ensure-ci-success

@cbeauchesne
cbeauchesne marked this pull request as ready for review May 13, 2025 09:31
@cbeauchesne
cbeauchesne requested a review from a team as a code owner May 13, 2025 09:31
@cbeauchesne
cbeauchesne requested a review from dougqh May 13, 2025 09:31
@cbeauchesne
cbeauchesne enabled auto-merge (squash) May 13, 2025 09:31
@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mcculls mcculls added type: bug fix Bug fix comp: tooling Build & Tooling labels May 13, 2025
@cbeauchesne
cbeauchesne merged commit 2fca456 into master May 13, 2025
@cbeauchesne
cbeauchesne deleted the cbeauchesne/fix-all-green branch May 13, 2025 10:17
@github-actions github-actions Bot added this to the 1.50.0 milestone May 13, 2025
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes
@bric3 bric3 bric3 approved these changes
@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/dd-trace-java-admin

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cbeauchesne @mcculls @bric3