Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Please try again by commenting @autotest review.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Disable async context capture only while
TimeoutAccessImpl.clear()registers its timeout-cancellation callback, using the existing async-propagation-disable instrumentation.Add an exact class-filter exception for
TimeoutAccessImpl. The existingTimeoutAccessImpl$*entry covers nested classes, not the enclosing class containingclear().Motivation
Play 2.6–2.8 smoke diagnostics exposed unresolved continuations captured by this cleanup callback. It waits on request-entity completion, which can remain unresolved even after the response completes.
This callback only cancels a timer; it does not need request context. Actual timeout handlers and normal request propagation remain unchanged.
flowchart LR A[Response completes] --> B[TimeoutAccessImpl.clear] B --> C[Register cancellation callback] C --> D[Wait for entity completion] D --> E[Cancel timeout task] B -. Previously captured request context .-> F[Unresolved continuation] style F fill:#f8d7da,stroke:#dc3545 style C fill:#d4edda,stroke:#28a745Here we remove the unwanted context capture without changing cancellation behavior.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]