Fix continuation cleanup when Apache async HTTP submission fails - #12613
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Please try again by commenting @autotest review.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
229cd9e
into
master
What Does This Do
Release the captured parent continuation when Apache async HTTP request submission throws synchronously, before a callback takes ownership.
Previously, the exceptional exit finished the client span but left the parent continuation unresolved. Normal completion, failure, and cancellation callbacks remain unchanged.
flowchart LR A[Capture parent continuation] --> B[Submit request] B -->|Accepted| C[Callback resolves continuation] B -->|Throws synchronously| D[Finish client span] D --> E[Release parent continuation — added] style E fill:#d4edda,stroke:#28a745Motivation
Smoke-test continuation diagnostics prompted this investigation. A focused regression confirmed that submitting through an unstarted or closed Apache 4.0 client leaks the captured continuation.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]