Skip to content

Fix continuation cleanup when Apache async HTTP submission fails - #12613

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/apache-async-submit-cleanup
Sep 24, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/apache-async-submit-cleanup

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Release the captured parent continuation when Apache async HTTP request submission throws synchronously, before a callback takes ownership.

Previously, the exceptional exit finished the client span but left the parent continuation unresolved. Normal completion, failure, and cancellation callbacks remain unchanged.

flowchart LR
    A[Capture parent continuation] --> B[Submit request]
    B -->|Accepted| C[Callback resolves continuation]
    B -->|Throws synchronously| D[Finish client span]
    D --> E[Release parent continuation — added]
    style E fill:#d4edda,stroke:#28a745
Loading

Motivation

Smoke-test continuation diagnostics prompted this investigation. A focused regression confirmed that submitting through an unstarted or closed Apache 4.0 client leaks the captured continuation.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner September 23, 2026 15:06
@amarziali amarziali added the type: bug fix Bug fix label Sep 23, 2026
@amarziali
amarziali requested review from vandonr and removed request for a team September 23, 2026 15:06
@amarziali amarziali added the inst: others All other instrumentations label Sep 23, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T15:10:17.779920Z 5d82d2d PR opened
🔒 Security Review ✅ Completed 2026-09-23T15:10:59.001648Z 5d82d2d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@amarziali amarziali added the tag: override groovy enforcement Override the "Enforce Groovy Migration" check label Sep 23, 2026
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.27% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5d82d2d | Docs | Give us feedback!

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Autotest was unable to complete this review. View session

Please try again by commenting @autotest review.

@dd-octo-sts

dd-octo-sts Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.04 s 14.07 s [-1.2%; +0.7%] (no difference)
startup:insecure-bank:tracing:Agent 12.97 s 13.06 s [-1.3%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.08 s 16.83 s [+0.6%; +2.4%] (maybe worse)
startup:petclinic:iast:Agent 17.05 s 17.00 s [-0.4%; +1.0%] (no difference)
startup:petclinic:profiling:Agent 16.79 s 16.90 s [-1.7%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.84 s 16.59 s [+0.4%; +2.6%] (maybe worse)
startup:petclinic:tracing:Agent 15.68 s 15.67 s [-5.7%; +5.9%] (unstable)

Commit: 5d82d2d1 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-24 13:42:24 UTC ℹ️ Start processing command /merge


2026-09-24 13:42:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-24 14:39:39 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 229cd9e into master Sep 24, 2026
612 of 619 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/apache-async-submit-cleanup branch September 24, 2026 14:39
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants