Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM.
Left minor code-style comments.
There was a problem hiding this comment.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
The first AI Guard evaluation can start a shaded OkHttp connection-pool worker while the
ai_guardspan is active. Thread instrumentation captures that context and keeps it active for the worker’s lifetime.The evaluation span itself finishes correctly, but pool maintenance is not part of the request and should not retain its context. Smoke continuation diagnostics exposed this unintended propagation.
Motivation
Disable async propagation only around AI Guard’s synchronous HTTP execution, restoring the previous setting in
finally.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]