Conversation
amarziali
added this pull request to stack #12526
September 16, 2026 14:11
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Make strict trace writing mandatory for instrumentation tests.
Motivation
Disabling strict trace writes allowed incomplete traces and continuation lifecycle problems to be hidden. Instrumentation tests should expose those problems so they can be diagnosed and fixed.
If a continuation problem cannot be fixed immediately, the test should be quarantined with
@Flakyand a useful reason or tracked issue.@TrackScopeContinuations(enabled = false, reason = "...")remains available only for a proven incompatibility with the diagnostic itself. It does not disable strict trace writes.flowchart TD A[Instrumentation test] --> B[Strict trace writes enabled] B --> C{Continuation failure?} C -->|No| D[Test passes] C -->|Real lifecycle problem| E[Fix ownership or cleanup] E --> D E -->|Cannot fix immediately| F["@Flaky with reason or issue"] C -->|Diagnostic incompatibility| G["Disable tracking narrowly<br/>with documented reason"] G --> H[Strict trace writes remain enabled]Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]