Skip to content

Avoid abandoning Guidewire test continuations - #12518

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/fix-guidewire-delayed-worker-test
Sep 16, 2026
Merged

Avoid abandoning Guidewire test continuations#12518
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/fix-guidewire-delayed-worker-test

Conversation

@amarziali

@amarziali amarziali commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Motivation

Updates the Guidewire delayed-worker test to eventually run the worker and consume its captured continuation.

I'm opening this PR since continuation leakage test are gonna be enforced so that I'd like this test not to fail in the future.

The test still verifies that an intervening trace remains independent, while avoiding an intentional continuation leak at the end of the test.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the type: feature Enhancements and improvements label Sep 16, 2026
@amarziali
amarziali requested a review from a team as a code owner September 16, 2026 07:50
@amarziali amarziali added the comp: testing Testing label Sep 16, 2026
@amarziali
amarziali requested review from ygree and removed request for a team September 16, 2026 07:50
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label Sep 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T07:52:21.546171Z eb757fb PR opened
🔒 Security Review ✅ Completed 2026-09-16T07:52:56.840031Z eb757fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-official[bot]
datadog-official Bot reviewed Sep 16, 2026
View reviewed changes

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The delayed worker runs after the independent trace and consumes its captured continuation. The test still confirms that the independent trace remains a separate root.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit eb757fb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-official

datadog-official Bot commented Sep 16, 2026 •
edited by datadog-prod-us1-6 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.04% (-0.06%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb757fb | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.82 s 14.68 s [+0.2%; +1.7%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.56 s 13.68 s [-1.7%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.68 s 17.47 s [+0.4%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 17.51 s 17.61 s [-1.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 17.40 s 17.24 s [-0.7%; +2.5%] (no difference)
startup:petclinic:sca:Agent 17.56 s 17.44 s [-0.3%; +1.7%] (no difference)
startup:petclinic:tracing:Agent 16.60 s 16.62 s [-1.2%; +0.9%] (no difference)

Commit: eb757fb1 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali amarziali mentioned this pull request Sep 16, 2026
Open
@amarziali

amarziali commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-16 08:58:51 UTC ℹ️ Start processing command /merge

2026-09-16 08:58:56 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-09-16 10:11:29 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d079beb into master Sep 16, 2026
605 of 608 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/fix-guidewire-delayed-worker-test branch September 16, 2026 10:11
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 16, 2026
jandro996 pushed a commit that referenced this pull request Sep 17, 2026
@amarziali @jandro996
Avoid abandoning Guidewire test continuations (#12518)
7bc72c3 
Avoid abandoning Guidewire test continuations

Co-authored-by: andrea.marziali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-official datadog-official[bot] datadog-official[bot] left review comments
@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes
@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-idm-java

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amarziali @ValentinZakharov