Skip to content

Pass enums as (boxed) basic primitives, not (boxed) as enums #468

Closed
Smartrak/dapper-dot-net
#3

Description

@mgravell

See #467, dotnet/corefx#1613, and the existing AdoNetEnumValue test. This is a recurring problem that needs to be fixed once and for all, especially if the "fix" is provider specific (in which case: fixing it in SqlClient won't fix it in Sqlite, npgsql, etc)

Activity

  1. changed the title [-]Pass enums as untyped primitives, not boxed as enums[/-] [+]Pass enums as (boxed) untyped primitives, not (boxed) as enums[/+] on Feb 23, 2016
  2. changed the title [-]Pass enums as (boxed) untyped primitives, not (boxed) as enums[/-] [+]Pass enums as (boxed) basic primitives, not (boxed) as enums[/+] on Feb 23, 2016
  3. mgravell commented on Feb 23, 2016

    @mgravell
    MemberAuthor

    Hmm, yeah, boxes as the original type:

    il.Emit(OpCodes.Box, prop.PropertyType);
        // stack is [parameters] [[parameters]] [parameter] [parameter] [boxed-value]
    

    will need to fix

  4. added a commit that references this issue on Feb 23, 2016
    b9288b4
  5. added a commit that references this issue on May 14, 2019
    a22b021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions