Skip to content

DCC bug 406 - Download plan with coversheet is broken. #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycarrick-ed merged 2 commits into from
Apr 14, 2022
Merged

DCC bug 406 - Download plan with coversheet is broken. #3158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1a073a
DCC bug 406 - Download plan with coversheet is broken.
Apr 14, 2022
f22c0e7
Merge branch 'development' into dcc_bug_703_Error_406_Admins_plan_page
raycarrick-ed Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions app/models/concerns/exportable_plan.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,9 @@ def prepare_coversheet
# rubocop:enable Metrics/AbcSize
# rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity

# rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/PerceivedComplexity
# rubocop:disable Metrics/MethodLength, Metrics/AbcSize
def prepare_coversheet_for_csv(csv, _headings, hash)
csv << [if hash[:attribution].many?
_('Creators: ')
else
_('Creator:')
end, format(_('%{authors}'), authors: hash[:attribution].join(', '))]
csv << [_('Creator:'), format(_('%{author}'), author: hash[:attribution])]
csv << ['Affiliation: ', format(_('%{affiliation}'), affiliation: hash[:affiliation])]
csv << if hash[:funder].present?
[_('Template: '), format(_('%{funder}'), funder: hash[:funder])]
Expand All @@ -161,7 +157,7 @@ def prepare_coversheet_for_csv(csv, _headings, hash)
csv << []
csv << []
end
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize, Metrics/PerceivedComplexity
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize

# rubocop:disable Metrics/AbcSize, Metrics/BlockLength, Metrics/MethodLength
# rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
Expand Down