DCC bug 406 - Download plan with coversheet is broken.#3158
Merged
raycarrick-ed merged 2 commits intoApr 14, 2022
Conversation
DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/703 Problem is that in concerns/exportable_plan.rb the method prepare_coversheet_for_csv(csv, _headings, hash) assumes hash[:attribution] is an ActiveRecord::Relation when it is always a string with a single author created in prepare_coversheet() method. Hence hash[:attribution].many? throws an error in csv << [if hash[:attribution].many?. Changes for fix: - in prepare_coversheet_for_csv(csv, _headings, hash) added csv << [_('Creator:'), format(_('%{author}'), author: hash[:attribution])] instead and removed csv << [if hash[:attribution].many?...]
johnpinto1
force-pushed
the
dcc_bug_703_Error_406_Admins_plan_page
branch
from
d952149 to
d1a073a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/703
Problem is that in concerns/exportable_plan.rb the method prepare_coversheet_for_csv(csv, _headings, hash) assumes hash[:attribution] is an ActiveRecord::Relation when it is always a string with a single author created in prepare_coversheet() method.
Hence hash[:attribution].many? throws an error in
csv << [if hash[:attribution].many?.
Changes for fix:
csv << [('Creator:'), format(_('%{author}'), author: hash[:attribution])]
instead and removed
csv << [if hash[:attribution].many?...]
When one tried to download a plan as a csv file with coversheet one got an error.
