Fixes issue #146, Author showing problem#166
Merged
DIYgod merged 1 commit intoDIYgod:masterfrom Nov 24, 2017
MPierre9:author-not-showing-fix
Merged
Fixes issue #146, Author showing problem#166DIYgod merged 1 commit intoDIYgod:masterfrom MPierre9:author-not-showing-fix
DIYgod merged 1 commit intoDIYgod:masterfrom
MPierre9:author-not-showing-fix
Conversation
micooz
approved these changes
Nov 24, 2017
|
pr 的话不建议修改 dist 目录文件内容。 |
Contributor
Author
|
@sinchang How should I implement the change without modifying APlayer.min.js in dist? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #146 by adding a ternary operator that checks if Author is blank or not. If author is blank nothing is displayed. If author is not blank it displays the usual "Song Title - Author"
Example: