You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not pass any TimeOut property to ConvertAPI and set HTTP Client timeout to 1800 seconds #30
Do not pass any default TimeOut property to ConvertAPI and set HTTP Client timeout to 1800 seconds. The idea is to use the default converter timeout of ConvertAPI if no timeout is set and to prevent HTTP Client request deadlock and set the default HTTPClient timeout to 1800 seconds.
If, however, timeout is set we handle it as before, pass a timeout to ConvertAPI and set HTTPClient Timeout to: ConvertAPITimeOut+conversion_timeout_delta
Activity
tomasr78 commentedon May 11, 2022
@laurynas-baltsoft Could you confirm that the TimeOut property is not hardcoded into the library and can be passed freely as all other properties?
laurynas-convertapi commentedon Jun 26, 2022
@tomasr78 conversion timeout is not set by default:
https://github.com/ConvertAPI/convertapi-php/blob/master/lib/ConvertApi/ConvertApi.php#L28
https://github.com/ConvertAPI/convertapi-php/blob/master/lib/ConvertApi/Task.php#L14
https://github.com/ConvertAPI/convertapi-php/blob/master/lib/ConvertApi/Client.php#L14
If it is configured, then timeout delta is used for http timeout:
https://github.com/ConvertAPI/convertapi-php/blob/master/lib/ConvertApi/Task.php#L28