Repository navigation
Declare the package license as MIT - #80
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped metadata change and changelog are consistent with the repository’s MIT license, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates the NuGet package license metadata to declare MIT explicitly, aligning it with the repository’s license.
Changes:
- Replaces deprecated
PackageLicenseUrlwithPackageLicenseExpressionset toMIT. - Documents the metadata correction in the 3.2.2 changelog entry.
| File | Description |
|---|---|
ConvertApi/ConvertApi.csproj |
Declares MIT using standard NuGet license metadata. |
CHANGELOG.md |
Records the license metadata correction for 3.2.2. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated
PackageLicenseUrl(https://www.convertapi.com/terms) with<PackageLicenseExpression>MIT</PackageLicenseExpression>, matching the repository'sLICENSEfile and the Java package. nuget.org and license scanners then show MIT instead of an unrecognised license. Checked withdotnet pack: the nuspec has<license type="expression">MIT</license>.Released as 3.2.2.
🤖 Generated with Claude Code