Fix ZMQ write JSON serialization for NumPy types, add regression test#256
Merged
pradeeban merged 1 commit intoFeb 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change?
ZMQ
write()sends raw NumPy values tosend_json_with_retry(), which is not JSON-serializable. This causes ZMQ messages to fail silently when payloads include NumPy scalars or arrays. File-basedwrite()already normalizes NumPy types, so behavior is inconsistent.What was the problem?
concore.write()sends rawvalnumpy.float64,numpy.int64, arrays, dicts with NumPy valuesHow I solved it
convert_numpy_to_python()beforesend_json_with_retry()mkconcore.pyregression from latestdevwhere absolute output paths were rejected bysafe_name(needed for CLI test to pass)Changes / Implementation
concore.pytests/test_concore.pyTestWriteZMQto verify conversion and JSON-safe payloadmkconcore.pysafe_namewhile still blocking shell metacharactersHow to Test Locally
python -m pytest -v tests/test_concore.py
python -m pytest -v
PR Checklist