Skip to content

fix(governance): handle private ruleset exclusions - #636

Merged
seonghobae merged 1 commit into
mainfrom
codex/fix-private-ruleset-scope-audit
Jul 29, 2026
Merged

fix(governance): handle private ruleset exclusions#636
seonghobae merged 1 commit into
mainfrom
codex/fix-private-ruleset-scope-audit

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • distinguish policy exclusions from repositories visible to the workflow token
  • keep public .github and noema exclusion probes mandatory
  • allow the private IRT-bibliography-set exclusion to remain outside token-scoped enumeration
  • add a regression test for the live failure mode

Root cause

The organization ruleset remained active and correctly excluded IRT-bibliography-set, but the central audit token could not enumerate that private repository. The inherited ruleset representation omits repository-name conditions, so the audit incorrectly treated token visibility as policy drift.

Verification

  • python3 -m pytest -q tests/test_central_required_workflow_ruleset_audit.py (15 passed)
  • python3 -m pytest -q (643 passed)
  • python3 -m ruff check changed files
  • python3 -m interrogate --fail-under=100 . (100%)
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 07df6b10-9062-4f43-8141-612891970b41

📥 Commits

Reviewing files that changed from the base of the PR and between cc3ceb2 and 9977eba.

📒 Files selected for processing (2)
  • scripts/ci/audit_central_required_workflows.py
  • tests/test_central_required_workflow_ruleset_audit.py

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit c53edb9 into main Jul 29, 2026
45 checks passed
@seonghobae
seonghobae deleted the codex/fix-private-ruleset-scope-audit branch July 29, 2026 04:04
@seonghobae seonghobae mentioned this pull request Sep 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@seonghobae