Skip to content

fix(noema): skip draft sidecar artifact upload - #2563

Open
seonghobae wants to merge 7 commits into
fix/full-suite-parser-locks-20260930from
fix/noema-draft-artifact-quota-20261003
Open

seonghobae wants to merge 7 commits into
fix/full-suite-parser-locks-20260930from
fix/noema-draft-artifact-quota-20261003

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

2026-10-03 action-identity oracle repair (authoritative)

  • Exact head: e8becafcf51b0d0063895f9889585eafd45cff49; tree: 4bd922621de35403e9a5cce2d34458e7d9acedc9; parent: 70b297431f8e52a53c79b24a684e858840b447ae; live base: canonical fix(ci): integrate parser, security, response, and coverage gates #2530 at e4fcd3ad277930b02a734302d7a6d0fd9315ec14.
  • RCA/RED: the prior YAML oracle selected the first step by display name. A compliant no-op decoy followed by the real fail-open upload-artifact therefore produced 10 passed. Its first action-identity repair was also case-sensitive, so a lower-case decoy plus mixed-case Actions/Upload-Artifact@… actual upload remained accepted until an executable alias mutation made the focused contract fail.
  • Smallest GREEN: inspect the parsed job's case-normalized uses identity, require exactly one actions/upload-artifact@ step, and bind that step's name, Draft gate, artifact name, and failure propagation. The alias mutation derives the live pinned reference, proves replacement occurred, and uses a successful CHANGELOG.md decoy upload. Production workflow behavior is unchanged.
  • Exact-tree local evidence: focused 10 passed; full branch-coverage suite 5,310 passed, 10 skipped, 40 subtests passed; production 18,767/18,767 statements and 7,648/7,648 branches; production Docstring coverage 100%; git diff --check GREEN.
  • Independent review found the case-alias and initially vacuous mutation-fixture defects; both were repaired. Final independent re-review: findings 0.
  • Fresh hosted exact-head receipts: Security 37128406643 jobs 111218368569/111218368655 and CodeQL 37128406628 job 111218368304 terminated before executable steps (steps=null); downstream jobs skipped. SAST 37128406727, job 111218369071, also terminated before executable steps (steps=null). These are infrastructure blockers, not acceptance evidence.
  • Review state: Ready for review / Proposed / status: blocked / merge HOLD. Fresh executable exact-head hosted Checks and a qualifying independent APPROVED review remain mandatory. No bypass, auto-merge, manual rerun, Force Push, destructive rebase, close, or predecessor retirement is authorized.

Earlier authority sections below are lineage evidence and are superseded by this section.

2026-10-03 canonical-owner restack (authoritative)

  • Exact head: 9b4e1dd553382a603ad8f8b7b8dc536bbbec6176; tree: f6a3c911f76bcb35578bb6581edf2dbea0e2d88f; live base: canonical fix(ci): integrate parser, security, response, and coverage gates #2530 at e4fcd3ad277930b02a734302d7a6d0fd9315ec14.
  • Ordinary parents are the prior leaf and current fix(ci): integrate parser, security, response, and coverage gates #2530; the branch ref advanced with force=false.
  • The restack carries fix(security): refresh shared PyJWT and PyO3 locks #2531's semantic prerelease oracle test, changelog, and exact RED/GREEN Gap evidence without copying or discarding the leaf delta. The effective leaf delta remains exactly four paths: Noema workflow, CHANGELOG, complete Gap baseline, and the Draft-admission regression contract.
  • Security 37081020281 and SAST 37081020104 failed before runner steps; CodeQL 37081020279 is Draft-skipped. These results are not acceptance evidence.
  • State remains Draft / Proposed / merge HOLD with zero qualifying approval. Fresh exact-head terminal Checks and independent review remain required. No bypass, auto-merge, manual rerun, Force Push, destructive rebase, close, or predecessor retirement is authorized.

Earlier authority sections below are lineage evidence and are superseded by this section.

Goal

Live Draft pull requests already skip contextual-orchestrator provisioning. Keep that intentional skip independent of GitHub Actions artifact storage quota while preserving fail-closed evidence upload for every non-Draft review.

RCA and executable evidence

  • Exact failing consumers:
    • .github#2530@153cbabecc067a4c67fc34bdc07e840b6f5b62d7, Noema job 111068439116
    • .github#2543@f5a1d47d0e744dbc2562ed7ce99a38cd18671742, Noema job 111069409132
  • Both jobs authenticated the exact live head, read draft=true, skipped every model/sidecar step, then ran Upload contextual-orchestrator sidecar evidence.
  • actions/upload-artifact found two pre-existing sidecar files and failed with Failed to CreateArtifact: Artifact storage quota has been hit.
  • RED 0141fee7ec11a003ec432c7e6c73dd858d9c30c8: focused contract 1 failed / 9 passed.
  • GREEN 3eff240e213c9d2a3e3f382243ffb4c4b6c1ab13: the upload uses the same live-Draft output as provisioning. Non-Draft upload failures remain job failures.

Verification

Exact tree: 1d41b1bcad3e13b5bf305120db4ef9f52d3c135e.

  • focused Draft admission: 10 passed
  • warnings-fatal full suite: 5,309 passed, 10 skipped, 40 subtests passed
  • production coverage: 18,767/18,767 statements; 7,648/7,648 branches (100%)
  • production Docstring coverage: 100%
  • warning-fatal compileall, YAML parse, and git diff --check: GREEN
  • actionlint was not present locally

Fresh exact-head hosted evidence

  • Required OpenCode run 37078264466: SUCCESS
  • Required Noema run 37078264533: FAILURE in job 111072965472; exact-head admission and live-Draft detection succeeded, model/sidecar provisioning skipped, then the protected main@37b10243… workflow executed the pre-repair upload condition and hit the same artifact-quota failure. A pull_request_target workflow source change cannot validate itself before protected integration.
  • Security run 37078264629 and SAST run 37078264618: pre-runner infrastructure failures; failed jobs have no runner and steps=[].
  • CodeQL and Strix: skipped while Draft.
  • unresolved review threads: 0; qualifying independent approvals: 0.

State

Draft / Proposed / merge HOLD. Fresh protected-source validation and qualifying independent review are required. No force push, destructive rebase, bypass, or paid/model fallback is introduced. Model-backed review remains fixed to orchestrator/free.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 158882df-b5c1-4deb-8624-ce3d2f5aae98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head direct review for 3eff240e213c9d2a3e3f382243ffb4c4b6c1ab13 (tree 1d41b1bcad3e13b5bf305120db4ef9f52d3c135e).

RCA is executable and bounded: RED 0141fee7… proves a live Draft still admitted the sidecar artifact upload, matching jobs 111068439116 and 111069409132. GREEN gates only that upload on the already-authoritative live-Draft output. Non-Draft evidence upload remains fail-closed; model routing, credential selection, exact-head admission, and publication are unchanged.

Fresh local exact-tree evidence: focused 10/10; warnings-fatal full suite 5,309 passed / 10 skipped / 40 subtests; 18,767/18,767 statements and 7,648/7,648 branches; Docstring 100%; compileall and diff check GREEN. actionlint was unavailable locally, so hosted workflow validation is still required.

Verdict: COMMENT / HOLD, not approval. Keep Draft until fresh exact-head hosted Checks and qualifying independent review are terminal.

@seonghobae seonghobae added type: bug Defect or incorrect behavior priority: high High-priority or P1 work status: draft Draft pull request area: ci-cd CI, GitHub Actions, checks, release, or supply chain labels Oct 2, 2026 — with ChatGPT Codex Connector

Copy link
Copy Markdown
Contributor Author

Current stack reconciliation — 2026-10-03

Canonical prerequisite #2530 has advanced to exact e4fcd3ad277930b02a734302d7a6d0fd9315ec14. Fresh exact comparison against this PR head 3eff240e213c9d2a3e3f382243ffb4c4b6c1ab13 is diverged: 2 ahead / 5 behind, with merge base 153cbabecc067a4c67fc34bdc07e840b6f5b62d7.

The four-file Draft-upload repair remains the valid leaf delta, but it is not current with the canonical writer stack. Keep Draft / Proposed and non-force merge-forward #2530 before any review admission. Fresh successor-head Checks and a qualifying independent approval remain required; predecessor results, skipped Draft CodeQL, or artifact-quota failure are not merge evidence.

Copy link
Copy Markdown
Contributor Author

Superseding current-stack receipt — 2026-10-03

Concurrent ordinary merge-forward head 9b4e1dd553382a603ad8f8b7b8dc536bbbec6176 now uses current #2530 exact e4fcd3ad277930b02a734302d7a6d0fd9315ec14 as its merge base. Fresh comparison is 3 ahead / 0 behind and retains exactly the four intended Draft-upload paths. The prior divergence receipt targeted superseded head 3eff240e….

Current state remains Draft / Proposed / merge HOLD: CodeQL 37081020279 is skipped, Security 37081020281 and SAST 37081020104 are terminal failures, qualifying approvals are 0, and unresolved threads are 0. Fresh protected-source validation is still required because this pull_request_target workflow change cannot validate itself before integration.

@seonghobae
seonghobae marked this pull request as ready for review October 3, 2026 04:18
@seonghobae seonghobae added the status: blocked Blocked by conflict, dependency, or required prerequisite label Oct 3, 2026 — with ChatGPT Codex Connector
@seonghobae seonghobae removed the status: draft Draft pull request label Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Exact-head review admission

Current authority: 050075e5e764be43faca28506dc38754b5aa2b8f / tree 91d0c4eccaf559ce3f5d388518e17cb8cc8eaf76.

  • Independent review of predecessor 9b4e1dd… found no workflow defect and one Minor contract-hardening gap: the test used substring matching and did not forbid continue-on-error.
  • Test-hardening f6f6a68d275430d37eace8f45d00f7a82737fedc requires exactly one canonical upload condition and rejects appended || true, continue-on-error: true, and missing/additional/altered if: lines.
  • Final 050075e5… only normalizes Python top-level spacing.
  • Independent exact-head re-review: Critical 0 / Important 0 / Minor 0; syntax compiles and the current workflow satisfies the strengthened oracle.
  • The executable workflow remains the original RED 0141fee7… → GREEN 3eff240e… repair: live Draft skips nonexistent sidecar evidence upload; false/missing/malformed/failed Draft detection retains non-Draft fail-closed upload, with no continue-on-error.

The PR is Ready for review, but remains Proposed / status: blocked / merge HOLD. Fresh terminal exact-head hosted Checks and a qualifying independent APPROVED review are still mandatory.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head owner repair review for 70b297431f8e52a53c79b24a684e858840b447ae (tree b61e08cd71afdf1afd03f9812f530a7d226a264f).

RCA/RED: at predecessor 050075e5…, adding job-level continue-on-error: true still produced 10 passing focused tests, so the claimed non-Draft fail-closed upload guarantee had a vacuous oracle.

GREEN: the contract now parses the workflow YAML and inspects the exact jobs.noema-review and upload-step mappings. It rejects canonical, quoted, and spaced-key bypasses at step and job scope, rejects the existing || true weakening, and proves later-job isolation. Production workflow behavior is unchanged.

Evidence:

  • focused: 10 passed
  • complete branch-coverage suite: 5,310 passed, 10 skipped, 40 subtests
  • production: 18,767/18,767 statements; 7,648/7,648 branches
  • Docstring: 100%
  • independent final re-review: findings 0
  • hosted exact-head SAST 37125355159, Security 37125355121, CodeQL 37125355137 terminated before executable steps; not acceptance evidence

Status remains Proposed / blocked / merge HOLD pending executable exact-head hosted Checks and qualifying independent approval.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head owner repair review for e8becafcf51b0d0063895f9889585eafd45cff49 (tree 4bd922621de35403e9a5cce2d34458e7d9acedc9).

RCA/RED: the prior oracle trusted the first matching display name, so a compliant no-op decoy could hide a second fail-open evidence upload while all 10 focused tests passed. A first action-identity draft also missed GitHub's case-insensitive owner/repository alias.

GREEN: the parsed job now requires exactly one case-normalized actions/upload-artifact@ action and binds that step's name, live-Draft condition, artifact name, and failure propagation. The mixed-case mutation derives the live pin, proves replacement, and uses an executable CHANGELOG.md decoy upload.

Evidence:

  • focused: 10 passed
  • complete branch-coverage suite: 5,310 passed, 10 skipped, 40 subtests
  • production: 18,767/18,767 statements; 7,648/7,648 branches
  • Docstring: 100%
  • final independent re-review: findings 0
  • hosted Security 37128406643 and CodeQL 37128406628 failed before steps; SAST 37128406727 remains queued with no steps

Status remains Proposed / blocked / merge HOLD pending executable exact-head hosted Checks and qualifying independent approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: high High-priority or P1 work status: blocked Blocked by conflict, dependency, or required prerequisite type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant