Skip to content

ci(actions): fold head coalescing into scheduler - #1882

Merged
seonghobae merged 1 commit into
mainfrom
codex/consolidate-current-head-coalescer
Sep 5, 2026
Merged

seonghobae merged 1 commit into
mainfrom
codex/consolidate-current-head-coalescer

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • run exact-head duplicate coalescing inside the existing merge-scheduler job
  • delete the standalone workflow that admitted a second runner for every central PR event
  • preserve immutable trusted-source materialization, event coverage, exact PR/head/base validation, and tests

Queue impact

Central pull-request events now create one fewer workflow job. The worker implementation and its fail-closed cancellation boundaries are unchanged.

Verification

  • uv run pytest -q: 2833 passed, 1 skipped, 21 subtests passed
  • actionlint .github/workflows/pr-review-merge-scheduler.yml .github/workflows/agent-review-runtime-quality-ci.yml .github/workflows/strix.yml
  • git diff --check

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6bd1316b-f76d-4e6c-bed4-e2b24de16fb2

📥 Commits

Reviewing files that changed from the base of the PR and between b5efbc2 and 85f4ef9.

📒 Files selected for processing (13)
  • .github/workflows/agent-review-runtime-quality-ci.yml
  • .github/workflows/current-head-run-coalescer.yml
  • .github/workflows/pr-review-merge-scheduler.yml
  • .github/workflows/strix.yml
  • CHANGELOG.md
  • docs/doctoring/current-head-run-coalescing.md
  • docs/doctoring/item13-stale-head-cancellation-audit-20260903.md
  • docs/doctoring/pr-review-merge-scheduler-trigger-audit-20260903.md
  • docs/doctoring/reusable-default-branch-scorecard-owner-20260903.md
  • docs/product-technical-gap-baseline.md
  • tests/test_current_head_coalescer_self_cancellation.py
  • tests/test_current_head_run_coalescer.py
  • tests/test_current_head_run_coalescer_review_regressions.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit af5932e into main Sep 5, 2026
5 of 17 checks passed
@seonghobae
seonghobae deleted the codex/consolidate-current-head-coalescer branch September 5, 2026 02:07
seonghobae added a commit that referenced this pull request Sep 5, 2026
#1882 deleted current-head-run-coalescer.yml and folded its steps into
pr-review-merge-scheduler.yml's scan-pr-queue job, so the coalescer no
longer has its own dedicated concurrency group -- the scheduler's existing
workflow-level group (scoped by repository and PR number) already covers
it. Updated the assertion to match the scheduler's actual group/
cancel-in-progress expression instead of the deleted file's.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
seonghobae added a commit that referenced this pull request Sep 16, 2026
Measures run counts, cancelled/superseded share, and run-level queue/
duration percentiles per (repo, workflow, trigger) group across all 79
non-archived org repos in the last 24h, per the ci-centralization task.

The baseline's live signature (single-digit in_progress vs 200+ queued
on fast-mlsirm/.github, and fast-mlsirm PR #1882-#1884 check suites
stuck QUEUED while #1885-#1886 succeeded) reproduces the org-wide
concurrent-job ceiling already documented in
docs/doctoring/actions-plan-concurrency-ceiling-20260903.md, not a
workflow-file duplication problem. ADR 0030 scopes what workflow
centralization can and can't do given that constraint, and records
that the one low-risk fix this task's Step 3 proposed (add missing
concurrency: blocks to required workflows) was already done org-wide
before this session started.

No workflow behavior changes in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant