Skip to content

Fix typo in get-examples script - #2

Open
tyb0807 wants to merge 1 commit into
CompilerTeaching:masterfrom
tyb0807:master
Open

Fix typo in get-examples script#2
tyb0807 wants to merge 1 commit into
CompilerTeaching:masterfrom
tyb0807:master

Conversation

@tyb0807

@tyb0807 tyb0807 commented Dec 1, 2017

Copy link
Copy Markdown

I guess this is another typo that should be fixed

@davidchisnall

Copy link
Copy Markdown
Contributor

This one is more subtle, because llvm-config now returns a version including the git hash. The correct fix for this is to change 5.1 to do a prefix match.

@tyb0807

tyb0807 commented Dec 1, 2017

Copy link
Copy Markdown
Author

Urgh, because my llvm-config --version really gives 5.0.1 without the git hash. So I should change RELEASE variable in setup_llvm.sh to release_51 and fix the corresponding version in get-examples.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants