Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Fix of the rounding error for negative numbers.#31

Merged
castarco merged 2 commits intoCoder-Spirit:masterfrom
codisart:rounding-fix
Apr 3, 2015
Merged

Fix of the rounding error for negative numbers.#31
castarco merged 2 commits intoCoder-Spirit:masterfrom
codisart:rounding-fix

Conversation

@codisart
Copy link
Copy Markdown
Contributor

@codisart codisart commented Apr 2, 2015

as showed in the issue #30.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling a9a28af on punkka:rounding-fix into d47cf15 on Litipk:master.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling a9a28af on punkka:rounding-fix into d47cf15 on Litipk:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling a9a28af on punkka:rounding-fix into d47cf15 on Litipk:master.

@codisart
Copy link
Copy Markdown
Contributor Author

codisart commented Apr 2, 2015

It seems that the cos test has an error.
WolframAlpha give me -0.722180643889243476826054 for the result of cos(15000000000). So the rounded value for the scale of 20 should be -0.72218064388924347683.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling bacb07c on punkka:rounding-fix into d47cf15 on Litipk:master.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling bacb07c on punkka:rounding-fix into d47cf15 on Litipk:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 96.26% when pulling bacb07c on punkka:rounding-fix into d47cf15 on Litipk:master.

@castarco
Copy link
Copy Markdown
Contributor

castarco commented Apr 2, 2015

Hi @punkka , thank you very much for your fix. I'll merge it this night :) .

castarco added a commit that referenced this pull request Apr 3, 2015
Fix of the rounding error for negative numbers, from @punkka .
@castarco castarco merged commit c76a4f1 into Coder-Spirit:master Apr 3, 2015
@codisart codisart deleted the rounding-fix branch April 3, 2015 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants