Skip to content

feat: Support binary data - #6708

Merged
Naktibalda merged 1 commit into
Codeception:5.0from
pongee:5.0
Nov 28, 2023
Merged

Naktibalda merged 1 commit into
Codeception:5.0from
pongee:5.0

Conversation

@pongee

@pongee pongee commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Hi,

Unfortunately if a suite got binary data, and this suite failed, then we can't see the problem. We see json_error problem:

In Descriptor.php line 52:                                                            
Malformed UTF-8 characters, possibly incorrectly encoded  

Expected (example):

There was 1 failure:
1) TestCest: My suite | "��K�r��B�\"
 Test  tests/TestCest.php:mySuite
 Step  Assert equals false,true
 Fail  Failed asserting that true matches expected false.

Scenario Steps:
 1. $I->assertEquals(false,true) 

Was same problem in codeception-db as well: Codeception/module-db#48

@Naktibalda
Naktibalda merged commit afb948b into Codeception:5.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants