Skip to content

Dependency injection support - #1168

Closed
splinter89 wants to merge 10 commits into
Codeception:masterfrom
splinter89:dependency-injection-support
Closed

splinter89 wants to merge 10 commits into
Codeception:masterfrom
splinter89:dependency-injection-support

Conversation

@splinter89

Copy link
Copy Markdown
Contributor

Resending #1164

@splinter89
splinter89 force-pushed the dependency-injection-support branch from ce18ed4 to 365be4a Compare October 29, 2014 10:23
@DavertMik

Copy link
Copy Markdown
Member

Thanks! Finally I merged this and it is now in master branch
Waiting to get this working for 2.1!

@splinter89
splinter89 force-pushed the dependency-injection-support branch from 365be4a to 236ce57 Compare February 11, 2015 09:08
@splinter89

Copy link
Copy Markdown
Contributor Author

Here you go

@DavertMik

Copy link
Copy Markdown
Member

@splinter89 thanks, I already merged this manually. Probably I will need to discuss some points. Are you in Skype these days?

@splinter89

Copy link
Copy Markdown
Contributor Author

I already merged this manually

I don't see it.
Why don't you use this PR?

Yes, I'm in Skype every day at work, usually 10am-6pm.

@DavertMik

Copy link
Copy Markdown
Member

@splinter89

I don't see it.
Why don't you use this PR?

Actually I did use this PR. This is how GitHub works, if PR can't be merged automatically it provides instructions to do that manually. Which actually I did. However it didn't track it. I merged your PR and I'm already working on moving everything to DI. I will push my changes to master later today.

Yes, I'm in Skype every day at work, usually 10am-6pm.
Am I using the wrong Skype or you are not replying? Ping me pls: davert.ua

@splinter89

Copy link
Copy Markdown
Contributor Author

I rebased this branch on top of master so you can merge it automatically now.

@DavertMik

Copy link
Copy Markdown
Member

Thank you, this branch is already merged. Di works really really smoothly on master and I feel really good of new features it brings! Thanks for good work!

@DavertMik DavertMik closed this Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants