This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London8 Daniel Piga Core2 week1 - #3
Closed
pigos4 wants to merge 1 commit into
Closed
Conversation
kolomiets
reviewed
Jan 29, 2022
| }, | ||
| }; | ||
| for (let recipe in recipes){ | ||
| console.log(recipes[recipe].title); |
There was a problem hiding this comment.
You use recipes[recipe] multiple times. I usually suggest introducing a variable to reduce code duplication. But in this case - would for-of loop work better?
| function createShoppingList(recipe) { | ||
| // write code here | ||
| function createShoppingList({ name, ingredients }) { | ||
| const { cupboardContents,fridgeContents} = pantry; |
| falafel: 7.25, | ||
| }; | ||
|
|
||
| const order = (price) => (balance) => |
There was a problem hiding this comment.
Very good - functions that produce functions is an important mental shift. That's a very powerful technique. Don't overuse it though :)
| // write code here | ||
|
|
||
| return wordCount; | ||
| return (string ? string.split(" ") : []).reduce( |
There was a problem hiding this comment.
This is a decent implementation and you used quite a few tricks here. However, I ague that you need to look for simpler (more readable) solutions:
function countWords(string) {
const wordCount = {};
const words = string ? string.split(" ") : []
for (const word of words) {
wordCount[word] = 1 + (wordCount[word] || 0)
}
return wordCount
}
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?