This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 9 - Farzaneh Haghani - JS2 - Week 1 - #180
Open
farzaneh-haghani wants to merge 5 commits into
Open
Conversation
ellietms
reviewed
Jan 2, 2023
| name: recipe.name, | ||
| items: missingArr | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Good job @farzaneh-haghani , well done.
One more thing you can do here, is maybe use concat function which will merge two arrays and put all of their values in one array and in that array you can just check once if the pantry has the fridge and cup board contents.
let allContents = pantry.fridgeContents.concat(pantry.cupboardContents) let missArr = recipe.ingredients.filter(eachIngredients => !allContents.includes(eachIngredients)) ....
| ); | ||
| return wordCount; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Well done, everything looks great, Keep going 🙌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details
Notes
What did you find easy? Yes
What did you find hard? No
What do you still not understand? Nothing
Any other notes? No