Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Manchester-NW5-Yousef Shaikhan-Javascript-week3 - #140

Open
youweb3 wants to merge 3 commits into
CodeYourFuture:mainfrom
youweb3:main
Open

Manchester-NW5-Yousef Shaikhan-Javascript-week3#140
youweb3 wants to merge 3 commits into
CodeYourFuture:mainfrom
youweb3:main

Conversation

@youweb3

@youweb3 youweb3 commented Sep 23, 2022

Copy link
Copy Markdown

No description provided.

@SteveLeicester

Copy link
Copy Markdown

Thanks for making a pull request for JS core week3.
A couple of general comments (which I always look out for :-) .

It is good to keep your code tidy - with proper indentation. So exercise B-While-loop, your evenNumbers function is a little untidy.

The second point is about commenting. It is a good habit to get into (think I said that before). function evenNumbersSum(n) provides a good example. Without a comment it is not clear if the function sums even numbers up to n or sums the first n even numbers (the instructions say the latter of course. It takes time to add these refinements but is worthwhile in the end.

Your E-for-loop exercise1 is a little odd. You added a for loop inside the while loop rather than replace. It gives a lot of output. exercise2 here looks good though.

You didn't manage to convert tube stations to upper case. Do you know this string function toUpperCase()?

A number of tests are failing - mostly because the code hasn't been implemented. Did you run out of time? Ithink your factorial function is close - just a syntax error result *= i not result* =i

Good effort though Yousef so thankyou.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants