Manchester-NW5-Yousef Shaikhan-Javascript-week3 - #140
Conversation
|
Thanks for making a pull request for JS core week3. It is good to keep your code tidy - with proper indentation. So exercise B-While-loop, your The second point is about commenting. It is a good habit to get into (think I said that before). Your E-for-loop exercise1 is a little odd. You added a for loop inside the while loop rather than replace. It gives a lot of output. exercise2 here looks good though. You didn't manage to convert tube stations to upper case. Do you know this string function A number of tests are failing - mostly because the code hasn't been implemented. Did you run out of time? Ithink your factorial function is close - just a syntax error Good effort though Yousef so thankyou. |
No description provided.