London 9 - Tony Arora - JavaScript-Core-1-Coursework-Week1 by Tony-devops · Pull Request #439 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

Tony-devops · 2022-11-24T14:06:25Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name: Tony Arora
Your City: London
Your Slack Name: Tony

Homework Details

Module: JS 1
Week: 1

Notes

What did you find easy? exercises and mandatory
What did you find hard? 8 ball
What do you still not understand? whether the 8 ball needed just whether the answer was between positive tonegative or all one random answer from the style of answer
Any other notes?

Dedekind561 · 2022-11-30T12:27:11Z

@@ -1,3 +1,5 @@
 // Start by creating a variable `greeting`
-
+let greeting="Hello World"


Hi @Tony-devops ,
Generally, when you're writing a variable declaration like this, you need to add a ; at the end. ; is used to indicate the end of a statement in JS. Sometimes a ; can be omitted but it's generally good practice to put a ; at the end of statements.

got it and same with sapcing. I need to shed the bad habits quickly. thanks

Dedekind561 · 2022-11-30T12:33:41Z

@@ -1,3 +1,5 @@
 // Start by creating a variable `message`
-
+let first="My name is"


I'll let you update the formatting here yourself 😃

Dedekind561 · 2022-11-30T12:34:10Z

-
+let first="My name is"
+let second=" King Tony"
+let message=first + second


Don't forget your semi-colons on the end of these statements, too.

Dedekind561 · 2022-11-30T12:35:40Z

@@ -1,3 +1,4 @@
 // Start by creating a variable `message`
-
+var name = "tony";


At the moment, you're using var to declare a varibable. We probably need to update our exercises: however, whenever you're declaring a variable be sure to use the let or const keyword. You'll learn more about why this is the case later on in the course.

Dedekind561 · 2022-11-30T12:36:59Z

@@ -1 +1,5 @@
 // Start by creating a variables `numberOfStudents` and `numberOfMentors`
+let numOfStudents=15;
+let numOfMentors=8;


Same issue again with spaces. Make sure you come back and tweak these lines 😃

Suggested change

let numOfMentors=8;

let numOfMentors = 8;

Dedekind561 · 2022-11-30T12:38:53Z

 // Start by creating a variables `numberOfStudents` and `numberOfMentors`
+let numOfStudents=15;
+let numOfMentors=8;
+let abs=numOfMentors+numOfStudents;


How can you improve the readability of your code here ?
You've created a variable called abs but it's not immediately apparent to me what this means. Remember your code is not only read by a computer, but also by other people too! So remember to think carefully about your choice of variable names.

Dedekind561 · 2022-11-30T12:40:24Z

@@ -1,5 +1,6 @@
 function halve(number) {
  // complete the function here
+  return number/2


Same issue with spacing applies here too - you can leave a space between number, the / and the 2.

Dedekind561 · 2022-11-30T12:41:36Z

@@ -1,5 +1,6 @@
 function triple(number) {
  // complete function here
+  return number*number*number


Spacing here 👓

And semi-colon 😄

Dedekind561 · 2022-11-30T12:44:31Z

@@ -1,6 +1,7 @@
 // Complete the function so that it takes input parameters
-function multiply() {
+function multiply(a,b) {


As with the other statements, in a function declaration here it is also convention to place spaces between parameters:

Suggested change

function multiply(a,b) {

function multiply(a, b) {

Dedekind561 · 2022-11-30T12:45:31Z

 // Write your function here
-
+function createGreeting(name){
+    return ("Nice to meet you " + name)


Here you've wrapped the return value in parentheses.
Do you need these parentheses in order for this function to work?

Dedekind561 · 2022-11-30T12:49:25Z

+function summed(a,b){
+    return a+b
+};
+let sum =summed(13,24)


summed is a cool variable name 😎. Can you explain why it is a good variable name in this context though?

Dedekind561 · 2022-11-30T13:02:40Z


-function convertToBRL() {}
+function convertToBRL(brazil) {
+  let ninetyNine=(brazil*99)/100;


Let's think about how we can make this code even clearer.
You've created a variable to save the value after you've taken away 1%. But what about the expression - ninetyNine * 5.7 - what does this represent ? Could you store this expression in a variable and give it a name so it's clearer what exactly you're calculating.

Co-authored-by: MitchLloyd <[email protected]>

Dedekind561 · 2022-12-01T17:06:24Z

  This function should expect to be called with any value which was returned by the shakeBall function.
 */
-function checkAnswer(answer) {
+function checkAnswer(string) {


Why did you change the name of this parameter from answer to string?

Dedekind561 · 2022-12-01T17:08:44Z

  //Write your code in here
+  for (let i=0; i<4;i++){
+    let list=listsOfAnswers[i];
+     for (let j = 0; j < 5; j++) {


Good attempt at variable naming here! A little wordy perhaps, but easier for me to work out what's going on in your code very quickly.

Dedekind561 · 2022-12-01T17:10:05Z


-function addTaxAndFormatCurrency() {}
+function addTaxAndFormatCurrency(currency) {
+let first=calculateSalesTax(currency);


Think about your indenting here - how can you update these variable declarations to make your code more readable. Also think about the naming of your variables here again. For example, what does the variable first mean ?

Dedekind561

Hi @Tony-devops,
I've just finished your review - sorry I didn't manage to finish it yesterday!
Well done on your first piece of JS Coursework!
I'm already seeing lots of good work here - good variable names and sound solutions to the exercises, including the extra exercises.
I think the main thing to focus on at the moment is your code formatting. If you fix this early on in the course it's going to make your life way easier :)
Well done!

Tony-devops · 2022-12-01T19:10:32Z

Thank you for your email. Thanks again for the time taken to help me get better. I have taken the points on board and will ensure the spacing and the semi-colon bad habit is nipped in the bud. will make the necessary changes in the code. thanks again

…

On Thu, Dec 1, 2022 at 6:53 PM MitchLloyd ***@***.***> wrote: ***@***.**** commented on this pull request. Hi @Tony-devops <https://github.com/Tony-devops>, I've just finished your review - sorry I didn't manage to finish it yesterday! Well done on your first piece of JS Coursework! I'm already seeing lots of good work here - good variable names and sound solutions to the exercises, including the extra exercises. I think the main thing to focus on the at the moment is your code formatting. If you fix this early on in the course it's going to make your life way easier :) Well done! — Reply to this email directly, view it on GitHub <#439 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2Q6657NFAEMMTUWUWRBBU3WLDXZHANCNFSM6AAAAAASKOAH24> . You are receiving this because you were mentioned.Message ID: <CodeYourFuture/JavaScript-Core-1-Coursework-Week1/pull/439/review/1201514293 @github.com>

Tony-devops added 10 commits November 21, 2022 18:40

syntax errors

a58ecdc

logic errors

8f5ddb1

functions output

093f6af

tax

a7fa40b

exercises

f30028a

exercises

ece1901

exercises

5f6040a

work in progress

6747c60

exercise

2eafb34

updated

5f8ab4f

Dedekind561 reviewed Nov 30, 2022

View reviewed changes

Comment thread exercises/D-strings/exercise.js Outdated

Dedekind561 reviewed Nov 30, 2022

View reviewed changes

Comment thread exercises/D-strings/exercise.js Outdated

Dedekind561 reviewed Nov 30, 2022

View reviewed changes

Tony-devops and others added 4 commits November 30, 2022 20:12

Update exercises/D-strings/exercise.js

e03156b

Co-authored-by: MitchLloyd <[email protected]>

Update exercises/D-strings/exercise.js

1a0fc74

Co-authored-by: MitchLloyd <[email protected]>

Update exercise.js

e42c3e6

Update exercise.js

7a462a4

Dedekind561 reviewed Dec 1, 2022

View reviewed changes

Dedekind561 added the reviewed label Dec 1, 2022

		@@ -1,3 +1,5 @@
		// Start by creating a variable `greeting`

		let greeting="Hello World"

		@@ -1,3 +1,5 @@
		// Start by creating a variable `message`

		let first="My name is"

		@@ -1,3 +1,4 @@
		// Start by creating a variable `message`

		var name = "tony";

Uh oh!

Uh oh!

Conversation

Tony-devops commented Nov 24, 2022

Your Details

Homework Details

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dedekind561 Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dedekind561 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tony-devops commented Dec 1, 2022 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dedekind561 Nov 30, 2022 •

edited

Loading

Dedekind561 left a comment •

edited

Loading