This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 9 - Abdulmajid Rammali - JS-Core-1 - Week 1 - #427
Open
Abdulmajidram wants to merge 1 commit into
Open
London Class 9 - Abdulmajid Rammali - JS-Core-1 - Week 1#427Abdulmajidram wants to merge 1 commit into
Abdulmajidram wants to merge 1 commit into
Conversation
Abdulmajidram
changed the title
zahraateee
reviewed
Nov 23, 2022
| @@ -1,3 +1,5 @@ | |||
| const name = " Daniel "; | |||
| const myName = " Daniel "; | |||
Author
There was a problem hiding this comment.
Thanks for the feedback, is it for only this one or you mean in general?
cause if in general then yeah I should of used Ellie advice to use let :D
gladwindos
reviewed
Nov 25, 2022
gladwindos
left a comment
gladwindos
left a comment
There was a problem hiding this comment.
This looks really good! The only thing I would suggest is to get in the habit of using const instead of let or var when you know the variable you are creating is not going to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? exercise
What did you find hard?
last few exercises
What do you still not understand?
need revision on functions
Any other notes?