This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 7 - Aisha Khan - JavaScript-Core-1-Week 1 - #38
Closed
aishak05 wants to merge 5 commits into
Closed
Conversation
Laura-TM
reviewed
Jan 20, 2021
| // Start by creating a variable `greeting` | ||
|
|
||
|
|
||
| var greeting = "Hello World" |
There was a problem hiding this comment.
Perhaps you could add a (;) at the end of this variable.
Laura-TM
reviewed
Jan 20, 2021
| console.log(message); | ||
| var name = "Aisha"; | ||
| var nameLength = name.length; | ||
| var message = "My name is " + name + " and the length of name is " +nameLength +" characters long." |
There was a problem hiding this comment.
Maybe we could do with a pronoun just before name on " and the length of name is " and a space before nameLength.
Laura-TM
reviewed
Jan 20, 2021
| console.log(roughPercentageStudents); | ||
|
|
||
| const percentageMentors = numberOfMentors / sum *100; | ||
| const roughPercentageMentors = Math.round(percentageMentors); |
|
Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details