This repository was archived by the owner on Jan 14, 2024. It is now read-only.
ZA2-Anthony Mogotlane-JavaScript Core 1 Coursework-W1 - #287
Closed
AnthonyMogotlane wants to merge 9 commits into
Closed
ZA2-Anthony Mogotlane-JavaScript Core 1 Coursework-W1#287AnthonyMogotlane wants to merge 9 commits into
AnthonyMogotlane wants to merge 9 commits into
Conversation
M3ntalist
reviewed
Jun 30, 2022
| "negative", | ||
| "very negative", | ||
| ]); | ||
| // expect(checkAnswer(answer)).toBeOneOf([ |
There was a problem hiding this comment.
I believe you were not supposed to comment all that code work or modify it as per instructions
Author
There was a problem hiding this comment.
You are right, I'll rectify that. Thanks.
Uncommented a unit test and add a test runner: jest-extended.
Add extra-test script
dschouw-CYF
reviewed
Jul 23, 2022
dschouw-CYF
left a comment
dschouw-CYF
left a comment
There was a problem hiding this comment.
Well done on completing the required coursework as well as the additional exercises Anthony
| var numberOfMentors = 8; | ||
|
|
||
| function percentageCalc(number) { | ||
| return Math.round((number/(numberOfMentors + numberOfStudents)) * 100) + "%"; |
| /* BETTER PRACTICE */ | ||
|
|
||
| let goodCode = | ||
| let goodCode = add(startingValue, 10); |
There was a problem hiding this comment.
Good work on completing the additional exercise as well Anthony.
You may also consider combining all the function calls into one expression as follows:
let goodCode = format(multiply(add(startingValue, 10), 2));
| */ | ||
| function checkAnswer(answer) { | ||
| //Write your code in here | ||
| if (veryPositive.includes(answer)) return "very positive"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
View rendered exercises/G-numbers/README.md
View rendered exercises/K-functions-parameters/README.md
View rendered exercises/L-functions-nested/README.md