LONDON_9- Mehreen_Aziz - HTML/CSS Project - WEEK_2 - Level3 - #528
Open
Mehreenaziz wants to merge 10 commits into
Open
LONDON_9- Mehreen_Aziz - HTML/CSS Project - WEEK_2 - Level3#528Mehreenaziz wants to merge 10 commits into
Mehreenaziz wants to merge 10 commits into
Conversation
Mehreenaziz
changed the title
Mehreenaziz
changed the title
susanssky
reviewed
Nov 7, 2022
|
|
||
|
|
||
| body { | ||
| font-family: 'Roboto', sans-serif; |
There was a problem hiding this comment.
because index.html's font url is out of date, so please you update the font url in the index.html
https://fonts.google.com/specimen/Roboto
Suggested change
| font-family: 'Roboto', sans-serif; | |
| font-family: 'Roboto', sans-serif; |
Tony-devops
reviewed
Nov 11, 2022
| </footer> | ||
| </body> | ||
| </html> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
good use of semantic html and sections
Tony-devops
reviewed
Nov 11, 2022
Mehreenaziz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? I found it easy to do the flex box after finishing the previous exercise with the HTML/CSS project.
What did you find hard? I found it hard to keep track of the variety of the classes and IDs
What do you still not understand?
Any other notes?