NW5-Manchester-Doris Siu-HTML&CSS-Week1 - #476
Open
Doris-Siu wants to merge 5 commits into
Open
Conversation
leilafaez
reviewed
Aug 11, 2022
| } | ||
|
|
||
|
|
||
| .rect_4 { |
There was a problem hiding this comment.
Doris nice job :)
just use a meaningful class name in your html so when you use them as a selector in css your code is more readable.
leilafaez
reviewed
Aug 11, 2022
| <div class="main"> | ||
|
|
||
|
|
||
| <div class="hero"> |
There was a problem hiding this comment.
you can also use semantic html instead of div, such as
leilafaez
reviewed
Aug 11, 2022
| <h2 class="heading-underline">Everyone needs a little Karma.</h2> | ||
|
|
||
| </div> | ||
| <br> |
There was a problem hiding this comment.
for spacing between some parts you can use Margin or Padding instead of br :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? HTML
What did you find hard? CSS
What do you still not understand? /
Any other notes? /