Scotland class 5 - Ivan Zhukov - HTML/CSS - Week 2 - #216
Closed
zhkvivan wants to merge 14 commits into
Closed
Conversation
|
This is great work Ivan, well done :) The css solution for the mobile menu is really cool, not something I've seen before. Regarding the commit messages, I would say they are mostly fine. Some are a bit generic ('adding some text') so could be a bit more descriptive. I think that it sometimes helps to plan ahead what work you are doing so that when you commit it will be grouped together in a meaningful way, but this will make more sense once you're working on a larger project. |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
flexbox
What did you find hard?
mobile burger menu
What do you still not understand?
Any other notes?