Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London10 - Khalil Alhaydr -HTML-CSS-Week3-Cake Co - #497

Open
Khlil1313 wants to merge 9 commits into
CodeYourFuture:masterfrom
Khlil1313:master
Open

London10 - Khalil Alhaydr -HTML-CSS-Week3-Cake Co#497
Khlil1313 wants to merge 9 commits into
CodeYourFuture:masterfrom
Khlil1313:master

Conversation

@Khlil1313

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

Comment thread index.html
<title>Responsive Cake webpage</title>
<!-- Add a link to your css file here -->
<link rel="stylesheet" type="text/css" href="style.css" />
<script type="text/javascript">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good attempt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is getting called too early, which is why it cannot find the

with class .navbar_links_toggle

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like code

Comment thread index.html
<link rel="stylesheet" type="text/css" href="style.css" />
<script type="text/javascript">
function classToggle() {
const navs = document.querySelectorAll('.navbar_items')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would indent these two lines to the right to make it look like they are separate

@Khlil1313 Khlil1313 changed the title London10 - Khalil Alhaydr - Cake Co-week3 London10 - Khalil Alhaydr -HTML-CSS-Week3-Cake Co Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants