Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Scotland class 5 — CSS zoo project #74

Closed
bonboh wants to merge 3 commits into from
Closed

Scotland class 5 — CSS zoo project #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7f1575
fixed css
DCntrk Jun 4, 2021
61e3d80
question 6-9
DCntrk Jun 4, 2021
f3fd4bb
completed task 8-9
DCntrk Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions zoo-css-challenge/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<main>
<section class="introduction">
<h1>Birmingham Zoo</h1>
<p>‘The zoo is open every day of the year and features three major biomes: the Tropic Zone, Temperate Territory, and the Polar Circle. From tropical birds, to snow leopards, grizzly bears, and one of the nation’s largest colonies of Antarctic penguins, there are animals to enjoy in every season</p>
</section>

<div id="badge">
Expand Down Expand Up @@ -51,15 +52,15 @@ <h2>Bears</h2>
</section>

<section class="tigers">
<h2>Tiger</h2>
<h3>Top 5 Tiger Facts</h3>
<ol>
<h2>Tiger Facts</h2>
<!-- <h3>Top 5 Tiger Facts</h3> -->

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- <h3>Top 5 Tiger Facts</h3> -->

Software teams normally delete commented code, so we shouldn't commit commented code

<ul>
<li>Tigers are the largest cat species in the world reaching up to 3.3 meters in length and weighing up to 670 pounds!
<li>Tigers are easily recognizable with their dark vertical stripes and reddish/orange fur.
<li>The Bengal tiger is the most common tiger.
<li>Tigers live between 20-26 years in the wild.
<li>Unlike most other cats, tigers are great swimmers and actually like the water.
</ol>
</ul>
</section>

<section class="giraffe">
Expand Down Expand Up @@ -90,6 +91,11 @@ <h4>Helping wild turtles in Seychelles</h4>
<h4>Learning about the rainforest</h4>
<a>Find out More</a>
</div>
<div class="card">
<time>2010-04-12</time>
<h4>Which big cat are you?</h4>
<a>Find out More</a>
</div>
</section>

<section class="education">
Expand All @@ -110,15 +116,15 @@ <h2>Are there any benefits or discounts for members?</h2>
<h2>Programs</h2>
<div class="card">
<h4>Children and Family Programs</h4>
<a>Find out More</a>
<a href="#">Find out More</a>
</div>
<div class="card">
<h4>Adult Programs</h4>
<a>Find out More</a>
<a href="#">Find out More</a>
</div>
<div class="card">
<h4>Youth and young adults</h4>
<a>Find out More</a>
<a href="#">Find out More</a>
</div>
<h3>Useful Links</h3>
<p>
Expand Down
55 changes: 47 additions & 8 deletions zoo-css-challenge/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ header {
width: 100%;
padding: 20px;
}

#logo{
border:none;
}
Comment on lines +11 to +13

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#logo{
border:none;
}

Instead of adding border:none;, we could instead delete the border CSS below

-img {
-  border: 5px solid #8075ff;
-}

nav {
display: inline-block;
width: 100%;
Expand Down Expand Up @@ -76,6 +78,8 @@ footer {
}

.introduction {
background-color:#fff ;
line-height: 1.5;
}

#badge {
Expand All @@ -85,13 +89,14 @@ footer {
border-radius: 50%;
display: inline-block;
position: fixed;
bottom: 20px;
top: 20px;
right: 20px;

display: flex;
justify-content: center;
align-content: center;
flex-direction: column;
transition: ease 2s;

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transition: ease 2s;
transition: background-color 2s ease;

The documentation says we should provide the properties in this order

https://developer.mozilla.org/en-US/docs/Web/CSS/transition

}

#badge:hover {
Expand All @@ -105,25 +110,44 @@ footer {

.image-container img {
vertical-align: top;
border: 5px solid #747c92;
border: 5px solid #3660d3;
}

.image-container img:nth-child(2) {
vertical-align: top;
border: 5px solid #dd2626;
}
.image-container img:first-of-type {
vertical-align: bottom;
vertical-align: top;
border: 5px solid #abdf88;


}

.tigers {
background-color: #0b3c49;
color: #f0e100;
}
.tigers h2, h3{

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.tigers h2, h3{
.tigers h2, .tigers h3{

The h3 selector will change the colour for all h3s on the page, but the task is to only change it for the tigers section so we should update the selector to .tigers h3

color:#F9CDCD !important;
}

.giraffe {
background-color: #465775;
color: #56e39f;
background-color: #483C46;
color: #BEEE62;
}
.giraffe p:nth-child(1){
font-size:larger ;

}

.giraffe h2 {
color: #ef6f6c;
color: #F4743B;
}
.news h2{
display: flex;
justify-content: center;
align-items: center;
Comment on lines +148 to +150

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: flex;
justify-content: center;
align-items: center;
text-align: center;

Alternatively, we could use text-align: center; here

}

.card {
Expand Down Expand Up @@ -166,18 +190,32 @@ footer {
background-color: rgba(255, 255, 255, 0.75);
padding: 50px;
max-width: 400px;
border-radius: 30px;

}

.education-container h3,
.education-container p {
margin-bottom: 1em;
}
.education-container button{

font-size: larger;

}
.education-container button:hover{

@bonboh bonboh Jun 13, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.education-container button:hover{
.education-container button:focus,
.education-container button:hover{

We should add a focus style too for keyboard users who use the Tab key to move to the button

background-color: #ccc8f5;
color: #6320ee;

}

/*Membership*/

.membership {
text-align: center;
background-color: #fffffc;
width: 700px;
margin: auto;
}

.membership h2 {
Expand All @@ -191,5 +229,6 @@ footer {
/*Programs*/

.programs .card {
display: block;
display: inline-block;
width: 25%;
}