Skip to content

fix(orm): resolve MyBatis sources and merge tables by primary key - #1778

Merged
Shashankss1205 merged 1 commit into
mainfrom
fix/mybatis-source-resolution-890
Oct 15, 2026
Merged

Shashankss1205 merged 1 commit into
mainfrom
fix/mybatis-source-resolution-890

Conversation

@Shashankss1205

Copy link
Copy Markdown
Collaborator

MyBatis links could disappear because the writer required class_context, which semantic definitions can omit, and matched short names across packages/repositories. Resolve the XML namespace against unique Java declarations already parsed for this repository, then match each method by its exact source path and name. Ambiguous or unknown namespaces are skipped with a warning instead of guessed.

Native tests also exposed DbTable MERGEs keyed by name even though the schema's primary key is fqn. Correct the MyBatis, annotation-query and ORM-mapping writers, backfill missing datasource values and preserve existing ones. Report submitted mapper records rather than claiming every input became a written edge.

Closes #890. Troubleshooting now explains force reindexing and ambiguous namespace handling.

Validation: 20 focused namespace/Java/native cases pass. Native Kuzu and Ladybug runs execute XML → Java interface → READS/WRITES, same short names in different packages and another repository, missing class_context, unresolved records, pre-existing-table datasource backfill, datasource preservation, annotation-query links and MAPS_TO. The two previous source-string assertions are replaced by these native behavioral checks. Writer regression scope: 63 passed, 1 skipped. Full local unit suite: 1,698 passed, 8 skipped. New code/tests pass Ruff F/E9 and git diff --check. Full CI must pass before merge. No license changes.

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
code-graph-context-pack Ready Ready Preview Oct 15, 2026 2:16pm UTC

@github-actions

Copy link
Copy Markdown
Contributor

Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Code Graph Analysis

fix(orm): resolve MyBatis sources and merge tables by primary key (#1778)

📊 Interactive Visualization

View the blast radius graph: PR Reviewer Dashboard

📦 Artifacts

The graph JSON has been uploaded as a build artifact: pr-code-graph-1778


Generated by CodeGraphContext using FalkorDB Lite

@Shashankss1205 Shashankss1205 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. Native Kuzu/Ladybug tests execute actual XML namespace resolution, exact Java-path matching without class_context, repository/package isolation, READS/WRITES and MAPS_TO edges, and datasource backfill/preservation. FQN table-key corrections cover all three affected ORM writer paths. Ambiguous namespace records are skipped with a warning; submitted counts are not mislabeled as actual written-edge counts. Local unit scope: 1,698 passed / 8 skipped. Final combined unit+integration scope including #1777 and both website fixes: 1,828 passed / 8 skipped; combined website build passes. All current-head CI checks pass, including Python 3.12–3.14, platform E2E, strict four-backend parity and packaging/security. Existing missing-edge indexes require force reindexing as documented.

@Shashankss1205
Shashankss1205 merged commit a2ab44a into main Oct 15, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog tasks to Done in CGC Progress Board Oct 15, 2026

This branch was successfully deployed

1 active deployment
Preview — fe2f39f9 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix(mybatis): XML mapper READS/WRITES edges not matching Function nodes (2793 parsed → 68 written)

1 participant