Skip to content

fix(registry): support HTTPS GitLab bundle downloads - #1768

Merged
Shashankss1205 merged 1 commit into
mainfrom
maintenance/fix-1234-20261015
Oct 15, 2026
Merged

Shashankss1205 merged 1 commit into
mainfrom
maintenance/fix-1234-20261015

Conversation

@Shashankss1205

Copy link
Copy Markdown
Collaborator

Allows gitlab.com and raw.gitlab.com through the existing HTTPS download-host policy. Existing hostname-boundary and scheme checks remain in force.

Validation: allowed GitLab hosts plus HTTP, lookalike host, userinfo and loopback rejection regressions; helper/security regression suite: 55 passed. Ruff passes.

Closes #1234.

@vercel

vercel Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
code-graph-context-pack Ready Ready Preview Oct 15, 2026 10:54am UTC

@github-actions

Copy link
Copy Markdown
Contributor

Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Code Graph Analysis

fix(registry): support HTTPS GitLab bundle downloads (#1768)

📊 Interactive Visualization

View the blast radius graph: PR Reviewer Dashboard

📦 Artifacts

The graph JSON has been uploaded as a build artifact: pr-code-graph-1768


Generated by CodeGraphContext using FalkorDB Lite

@Shashankss1205 Shashankss1205 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed HTTPS and hostname boundary checks; new allowed hosts do not accept HTTP, lookalike domains, another userinfo host or loopback. Combined regression suite: 77 passed; Ruff passes. The strict parity job reproduced #1730's known 51 missing Variable endpoints and has been retried once with diagnostics linked there. No parity tolerance was added.

@Shashankss1205
Shashankss1205 merged commit d27df85 into main Oct 15, 2026
22 of 23 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog tasks to Done in CGC Progress Board Oct 15, 2026

This branch was successfully deployed

1 active deployment
Preview — 24a67282 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat: Add gitlab.com support to is_safe_download_url() in path_sandbox.py

1 participant