Repository navigation
test: enforce exact containment parity and diagnose missing variable endpoints - #1762
Open
Shashankss1205 wants to merge 5 commits into
Open
Shashankss1205 wants to merge 5 commits into
Shashankss1205 wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysistest: enforce exact containment parity and diagnose missing variable endpoints (#1762) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
Shashankss1205
changed the title
Shashankss1205
changed the title
Shashankss1205
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parity test accepts up to 64 missing CONTAINS edges, hiding #1730’s intermittent 51-edge Ladybug deficit. Remove the allowance and compare portable endpoint identities (label, relative path, name, line, occurrence index) so equal counts with different connections also fail.
CI evidence isolates all 51 missing edges to File→Variable links in
sample_project_typescript/src/utilities-helpers.ts; Kuzu, FalkorDB, and Neo4j agree on every other containment edge. Print bounded samples grouped by source file, capture every Variable node’s identity and normalized uid, and report whether missing targets exist. Upload complete statistics, edges and variable snapshots ascontainment-parity.jsonwith 14-day retention. A missing dump is an explicit error.Validation: 69 performance/parity/backend tests pass (1 skip), plus 21 native Kuzu identity/property tests. Seven parity guards pass on Python 3.12 and 3.14 and cover 1/51/64-edge deficits, equal-count identity mismatches, artifact persistence, bounded output and present/absent endpoint diagnosis. Native tests verify separate containment links for colliding symbols and no duplicate links after reindexing. Live Kuzu/Ladybug probes validate edge and variable snapshots. Ruff and
git diff --checkpass; published tree equals the validated local tree.Latest-head strict CI passes: all four backends have 4,727 CONTAINS edges with identical endpoint identities: https://github.com/CodeGraphContext/CodeGraphContext/actions/runs/37967834995 . Prior failure: https://github.com/CodeGraphContext/CodeGraphContext/actions/runs/37966285832 .
This restores the guard and evidence collection. The production writer is unchanged, so one green run does not establish a repair of the intermittent defect. Keep #1730 open until its underlying write defect is repaired. Main still contains the allowance until this correction merges. Independent approval and all passing checks required.
Follow-up to #1758, whose containment tolerance change I missed during review before merging.