Repository navigation
fix(scip): recognise scip-dotnet (+N) overloads and drop the marker from names - #1740
Merged
Shashankss1205 merged 4 commits intoOct 15, 2026
Merged
Conversation
scip-dotnet names method overloads Type#M()., Type#M(+1)., Type#M(+2). and reports kind 0 for all of them. ScipIndexParser keeps only the first overload as a definition and names the rest, and calls to them, M(+1) / M(+2). Occurrences are copied from real scip-dotnet output over a three-overload fixture. Co-Authored-By: Claude Sonnet 5 <[email protected]>
…rom names scip-dotnet disambiguates method overloads as Type#M(+N). and reports kind 0. The kind-0 fallback matched only the '().' suffix, so every overload but the first was dropped as a definition. _name_from_symbol stripped '()' but not '(+N)', so calls to those overloads were named 'M(+1)'. A callable descriptor is now '().' or '(+N).'. Parameter descriptors such as 'M(+1).(x)' are unaffected. The C++ zero-kind inference is unchanged. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
@PhysShell is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
…erload With (+N) overloads recognised, a C# file holds two `M` nodes. The SCIP nodes arrive with args == [] (scip-dotnet leaves display_name empty), and C# call records carry no arguments, so the Tree-sitter resolver resolves neither `M()` nor `M(1)`. Only the SCIP file-level edges remain. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Hfh5zciucKoUGUdKjq3GwV
- The SCIP pipeline matches a SCIP function to its Tree-sitter twin by (name, line) instead of name alone, and fills empty `args` from it. - The C# Tree-sitter parser records a call's arguments instead of a hard-coded empty list. The existing arity check can then tell M() from M(int). Both calls resolve Caller -> M to the matching overload again. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Hfh5zciucKoUGUdKjq3GwV
This was referenced Sep 28, 2026
Shashankss1205
approved these changes
Oct 9, 2026
Shashankss1205
left a comment
Shashankss1205
left a comment
Collaborator
There was a problem hiding this comment.
SCIP dotnet (+N) overload descriptors and line-specific C# augmentation fixes pass targeted tests; require real .NET fixture and CI.
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scip-dotnetdisambiguates C# method overloads asType#M().,Type#M(+1).,Type#M(+2).and currently reportsSymbolInformation.kind = 0for them.ScipIndexParseronly recognized the().suffix in its kind-0 fallback, so overloads after the first were dropped as function/method definitions._name_from_symbolalso kept the(+N)marker, producing names such asM(+1).This change:
().and(+N).as callable SCIP symbols in the existing kind-0 fallback;(+N)overload marker during name normalization;M(+1).(x)from being treated as callable definitions;Tests
scip-dotnetoutput.pytest tests/unit/tools -k scip: 28 passed.ruff check: no new violations.