Repository navigation
fix(viz): use filename instead of <module> for top-level script nodes - #1702
Closed
AloysJehwin wants to merge 2 commits into
Closed
AloysJehwin wants to merge 2 commits into
AloysJehwin wants to merge 2 commits into
Conversation
|
@AloysJehwin is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1681.
Top-level module nodes were all labeled
<module>, making multiple files indistinguishable in the call graph visualizer. When the node name is<module>, the label now uses the file basename instead, giving each file a unique, readable identifier in the graph.Note: The CI failures (Build Test 3.12/3.13/3.14, db-parity, e2e) are pre-existing failures on the
mainbranch unrelated to this change. Specifically:test_elisp_parser.py::test_parse_elisp_normalized_output—KeyError: 'sample-callback'fails on main (run 33686444387)test_verify_databases_parity.py::test_database_parity_e2e—ladybugdb exit code -11(SIGSEGV in ladybug library) fails on main (run 33686444386)ladybugdbcrash fails on main (run 33686444388)This PR is a re-submission of #1688 which was closed due to these pre-existing CI failures.