Repository navigation
fix(code-finder): match find_functions_by_argument against arg_types not parameter names - #1701
AloysJehwin wants to merge 2 commits into
Conversation
|
@AloysJehwin is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@AloysJehwin this is a resubmission of #1687, which was closed a few days ago because #1686 fixed #1685 first — that fix (including the embedded-backend To be clear about the norm here: when a PR is closed as an overlap of an earlier fix, re-opening the same diff doesn't change the outcome — the way to more merged contributions is new issues, and you've shown you're good at that (#1677 and #1680 were both excellent and merged same-day). |
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
2 participants
Fixes #1685.
find_functions_by_argumentwas matching againstParameter.name(the variable name) rather than the argument type. For typed languages like Java, type information lives onFunction.arg_types, not on theParameternode, so queries for types likeOrderFilterreturned no results.The Cypher query now uses
any(t IN f.arg_types WHERE t CONTAINS $arg_type)to match against the type list, with a fallback to parameter-name matching for untyped languages.Note: The CI failures (Build Test 3.12/3.13/3.14, db-parity, e2e) are pre-existing failures on the
mainbranch unrelated to this change. Specifically:test_elisp_parser.py::test_parse_elisp_normalized_output—KeyError: 'sample-callback'fails on main (run 33686444387)test_verify_databases_parity.py::test_database_parity_e2e—ladybugdb exit code -11(SIGSEGV in ladybug library) fails on main (run 33686444386)ladybugdbcrash fails on main (run 33686444388)This PR is a re-submission of #1687 which was closed due to these pre-existing CI failures.