Repository navigation
fix(bundle): guard exclude_labels against Typer OptionInfo (follow-up to #1692) - #1696
Merged
Merged
Conversation
…matic calls The golden harness calls bundle_export() as a plain function, where an unpassed Typer option arrives as its OptionInfo object — .split blew up and every golden's index/export subprocess failed. Same trap the CLI meta-test documents; guarded with an isinstance check.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysisfix(bundle): guard exclude_labels against Typer OptionInfo (follow-up to #1692) (#1696) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser-golden harness calls
bundle_export()programmatically, where unpassed Typer options arrive asOptionInfoobjects — the #1692exclude_labels.split(',')blew up and every golden's index/export subprocess failed. Guarded with an isinstance check (the same known trap the CLI meta-test documents for other commands). Golden verified green; unit suite 1459.