Skip to content

fix(viz): use filename instead of <module> for top-level script nodes - #1688

Closed
AloysJehwin wants to merge 1 commit into
CodeGraphContext:mainfrom
AloysJehwin:fix/visualizer-module-label-dedup
Closed

AloysJehwin wants to merge 1 commit into
CodeGraphContext:mainfrom
AloysJehwin:fix/visualizer-module-label-dedup

Conversation

@AloysJehwin

Copy link
Copy Markdown
Contributor

Fixes #1681.

Top-level module nodes were all labeled <module>, making multiple files indistinguishable in the call graph visualizer. When the node name is <module>, the label now uses the file basename instead, giving each file a unique, readable identifier in the graph.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

@AloysJehwin is attempting to deploy a commit to the shashankss1205's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-project-automation github-project-automation Bot moved this to Backlog tasks in CGC Progress Board Sep 2, 2026
@Shashankss1205

Copy link
Copy Markdown
Collaborator

Thanks @AloysJehwin — this was a solid, consistent implementation, but #1682 covered the same three sites, landed first (and is the issue reporter's own fix for #1681), and additionally handles the canvas-side fallback; it's merged now. Two of your calls influenced the final state: label consistency across render sites (I normalized #1682's one divergent format on merge) — though we kept the file extension, since a bare app is ambiguous against a function of the same name. Closing as overlapping; your other three merges today were much appreciated.

@AloysJehwin

Copy link
Copy Markdown
Contributor Author

All CI failures here are pre-existing on main and unrelated to this change:

  • Build Test (3.12/3.13/3.14): test_elisp_parser.py::test_parse_elisp_normalized_output — KeyError: 'sample-callback' — also fails on main (e.g. run 33686444387)
  • db-parity: ladybugdb exit code -11 (SIGSEGV in the ladybug shared library) — also fails on main (run 33686444386)
  • e2e: same ladybugdb crash — also fails on main (run 33686444388)

This PR could not be reopened (viewer lacks reopen permission despite being author). Re-submitted as #1702.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug/UI] Visualizer displays duplicate "<module>" labels instead of source filenames for top-level code

2 participants