Repository navigation
fix(parsers): #1660 leftovers — declaration-line convention, Ruby vars/values, Neo4j indexes for orphan labels - #1671
Merged
Merged
Conversation
…by class/global vars and values; Neo4j indexes for the falkordb-only labels
- kotlin/php: annotated/attributed declarations reported the annotation line
as line_number (the declaration node starts at its annotation). Both now
report the declaration proper — and their _get_parent_context walkers were
aligned to the same line, since Hilt/Previews resolution and the writer
join context line against the function's line_number.
- ruby: @@class_variables and $globals were never captured (missing node
types in the query); variable `value` was ALWAYS None because captures
bucketed by id() of tree-sitter's per-access wrapper objects (n1 == n2
while id(n1) != id(n2)) — bucketing by node span fixes it; and the
type ladder tested startswith("@") before "@@", leaving the class branch
dead.
- schema: EnumMember/Object/Mixin/Extension/Parameter had index statements
only in the is_falkordb branch, so Neo4j lookups on them were label scans
(#1653's closing observation). They now get (name, path) indexes on the
same pattern.
Kotlin/PHP goldens regenerated (property-level line shifts only — zero
node/edge count drift). Unit suite 1418 passed / 7 skipped; all 21 goldens
green.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysisfix(parsers): #1660 leftovers — declaration-line convention, Ruby vars/values, Neo4j indexes for orphan labels (#1671) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out #1660 (the 'Minor' split from the #1538 audit) plus the index gap #1653's author flagged:
@Deprecated/#[Attr]) asline_number. Both now report the declaration proper — and crucially, their_get_parent_contextwalkers were aligned to the same line, because Hilt/Previews resolution and the writer's linking join context-line against the function'sline_number(the Hilt/Previews suites caught the desync immediately when only one side moved).@@class_variablesand$globalswere invisible (missing node types in the query);valuewas alwaysNone— captures bucketed byid()of tree-sitter's fresh-per-access wrapper objects (n1 == n2whileid(n1) != id(n2)), fixed by bucketing on node span; and the type ladder tested@before@@, leaving the class branch dead.if is_falkordb— Neo4j lookups on them were unavoidable label scans. They now get(name, path)indexes on perf(schema): index (name, path) so relationship writes seek, not scan #1653's pattern, with the existing meta-tests extended.Kotlin/PHP goldens regenerated — property-level line shifts only, zero node/edge count drift. Unit suite 1418 passed / 7 skipped; all 21 goldens green.
Fixes #1660