Repository navigation
test(resolution): pin Rust Type::method() resolution end-to-end (#1658) - #1668
Merged
Merged
Conversation
The chain assembled across #1657 (impl-method class_context + scoped-call receiver types) and #1510 (label-aware called-context clause) makes scoped constructor calls resolve correctly: same-named news bind to their own impl and external Arc::new does not mis-bind locally. Pinned on a real embedded database so a regression in any of the three pieces fails this test.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
Contributor
🔍 PR Code Graph Analysistest(resolution): pin Rust Type::method() resolution end-to-end (#1658) (#1668) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out #1658 was three-quarters fixed by the time it was filed — the resolution wiring at
calls.py:1043already consumesinferred_obj_type, and the missing pieces were exactly what landed since: #1657 gave impl methodsclass_context(populatingclass_method_index) and scoped calls their receiver type, and #1510 stopped the writer dropping resolved edges whose target scope lives outsidecontext.Verified on the issue's suggested corpus against a real embedded database:
Worker::new()andPool::new()each bind to their own impl, andArc::new()produces no local edge. This PR pins that end-to-end chain as a regression test so a break in any piece fails loudly.Fixes #1658