Repository navigation
fix(writer): wire the label-aware called-context clause (#1510) - #1667
Merged
Merged
Conversation
…ped CALLS land (#1510) _called_context_clause existed with zero callers while the write path used an inline context-only predicate — so correctly-resolved calls whose target stores its scope in module_context (every Rust function) were filtered out at write time on Neo4j and binder-skipped on Kuzu. The helper is now label-aware (Variable stays context-only: the Kuzu Variable table declares no class/module_context columns) and actually called. Real-Kuzu regression test proves a module_context-scoped CALLS edge lands.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysisfix(writer): wire the label-aware called-context clause (#1510) (#1667) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dead helper the issue identified is now label-aware and actually wired in: Function matches
context | class_context | module_context; Variable stayscontext-only because the Kùzu Variable table declares no class/module_context columns and a missing-column reference binder-skips the whole batch on typed backends.Real-Kùzu regression test: a Rust-style function (scope only in
module_context, nocontextkey) + a resolved call withcalled_context='utils'→ the CALLS edge lands (it was dropped before). Unit suite 1413 passed / 7 skipped; all 21 goldens unchanged.Fixes #1510