Repository navigation
fix(cli): repair CI break from bundle signing (#1060) - #1599
Merged
Merged
Conversation
Two regressions from #1060, both caught by the integration suite: 1. bundle_export dereferences sign_key/encrypt_password. Called as a plain function rather than through Typer -- which tests/integration/test_parser_ goldens.py:273 does -- an omitted option keeps its OptionInfo sentinel. That sentinel is truthy, so `if sign_key:` passed and sign_key.encode() raised AttributeError, failing all 20 golden tests. Normalized at the top of the command; these two are the only options here that get dereferenced. 2. The new bundle verify/inspect/diff subcommands were not reflected in the CLI inventory tests. verify/inspect/diff each require a .cgc positional argument, so they are excluded from the bare-invocation smoke matrix the same way bundle merge already is. Full suites green: 1178 unit, 44 integration. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ |
Contributor
🔍 PR Code Graph Analysisfix(cli): repair CI break from bundle signing (#1060) (#1599) 📊 Interactive VisualizationView the blast radius graph: PR Reviewer Dashboard 📦 ArtifactsThe graph JSON has been uploaded as a build artifact: Generated by CodeGraphContext using FalkorDB Lite |
This was referenced Aug 13, 2026
Shashankss1205
added a commit
that referenced
this pull request
Aug 13, 2026
.cgc/config.json is generated by running `cgc index` in the repo root. It was committed accidentally in #1599 because .gitignore did not cover the directory, so `git add -A` swept it up. It has no effect on the parity suite (that indexes tests/fixtures/ sample_projects, not the repo root), but it should not be tracked. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red since #1060 merged (Build Testonf9b6e1be). Two regressions, both in the integration suite, which is why the unit suite stayed green.1.
bundle_exportblows up on Typer sentinels — 20 golden teststests/integration/test_parser_goldens.py:273callsbundle_exportas a plain function:Typer only resolves defaults when it invokes the command, so the omitted
sign_keykeeps itsOptionInfosentinel. That sentinel is truthy, so the newif sign_key:guard passes andsign_key.encode("utf-8")then raises:Every
test_language_goldencase failed on this.This is the bug class
test_command_delegation_and_exit_codesalready guards, but that meta-test only inspects command→command calls insidemain.py— it can't see external callers. Rather than only fixing the one call site, I normalized the two options at the top ofbundle_export, since they're the only ones here that get dereferenced rather than merely tested for truthiness. Any programmatic caller gets the same protection.2. New bundle subcommands missing from the CLI inventory tests
#1060 added
bundle verify,bundle inspectandbundle diffwithout updatingtest_cli_inventory_grouped_from_source(asserts an exact set) ortest_all_canonical_cli_commands_run_with_kuzudb(asserts the smoke matrix covers the inventory).All three take a required
.cgcpositional argument, so they can't be invoked bare the way that matrix invokes everything else — excluded with a comment, exactly asbundle mergealready is. Their behaviour is covered by the round-trip tests.Verification
My fault for merging #1060 on a green unit run without also running the integration suite — the signing feature itself is fine and round-trips correctly.