fix(parsers): capture PHP imports instead of trait uses - #1563

Fixes #1522. Full suite: 1078 passed, 7 skipped, no failures.

The bug

The imports query captured use_declaration — which in tree-sitter-php is the trait use inside a class body, the same node type php.py already relies on at line ~309 for trait handling. A top-level use App\Models\User; is a namespace_use_declaration.

This ran in both directions:

• Real imports were dropped entirely. PHP files produced no Module nodes and no IMPORTS edges, so resolution/calls.py had an empty local_imports map for PHP and no call to a class imported from another file could resolve.

• Trait uses were recorded as imports. The repo's own fixture has a conflict-resolution block inside a class:

  class ConflictResolver {
      use Alpha, Beta {
          Beta::execute insteadof Alpha;
          ...
      }

  That became a Module node named Alpha whose full_import_name was the entire block, newlines and all.

The fix

Capture namespace_use_clause rather than the declaration. That is the level that exists once per imported symbol, so the braced group form expands for free. The handler now reads the AST instead of regexing the declaration text:

Two secondary improvements that fell out of it:

• full_import_name is the clean fully-qualified path rather than raw source text (the same defect noted for Rust in bug(indexer): parser audit roundup — context attribution, wrong Module names, missing declarations and duplicate call records across 12 languages #1538).
• Rows are sorted by line number — query captures arrive in match order, so output was previously nondeterministic.

Trait handling is untouched and still works: a use Greets; inside a class yields imports == [] with Greets correctly in traits.

Golden

sample_project_php regenerated. Verified semantically rather than by line count:

REMOVED (bogus, trait-derived):
   'Alpha'  -> 'use Alpha, Beta {\n  Beta::execute insteadof Alpha; ... }'
   'Logger' -> 'use Logger;'
ADDED (real imports):
   'ClassLoader'  -> 'Composer\Autoload\ClassLoader'
   'Repository'   -> 'App\Models\Repository'
   'User'         -> 'App\Models\User'
   'UserService'  -> 'App\Services\UserService'
   'VersionParser'-> 'Composer\Semver\VersionParser'

New test file tests/unit/parsers/test_php_parser.py covers all five import forms, the trait-use case, and ordering.

🤖 Generated with Claude Code