Repository navigation
fix: fall back when GCF encoding fails - #1539
Merged
Shashankss1205 merged 1 commit intoAug 2, 2026
Merged
Shashankss1205 merged 1 commit into
Shashankss1205 merged 1 commit into
Conversation
|
@tomatotomata is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
Shashankss1205
approved these changes
Aug 2, 2026
Shashankss1205
left a comment
Shashankss1205
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: trial-merged onto main with #1540 and #1541 — full suite green (1063 passed, 7 skipped).
Correct fix for #1518. The try/except is scoped tightly around encoder(result) so only encode-time failures fall through, and exc_info=True at debug level keeps the traceback recoverable without noise. The added test forces a failing encoder rather than mocking the fallback, which is the right way to prove it. Thanks!
github-project-automation
Bot
moved this from Backlog tasks
to Done
in CGC Progress Board
This was referenced Aug 2, 2026
Shashankss1205
added a commit
that referenced
this pull request
Aug 2, 2026
Bug-fix release. Since 0.5.4 on PyPI: - fix(indexer): record non-code files on the SCIP path so `cgc index` stops reporting a partial index forever (#1565, #1566) - fix(parsers): capture PHP imports rather than trait uses (#1522, #1563) - fix(parsers): recover Python annotated parameters — 40.3% of parameters were being dropped — and Go grouped imports (#1520, #1521, #1561) - fix(graph): always sanitize bundle filenames (#1517, #1541) - fix(cli/mcp): read import aliases from the IMPORTS relationship (#1515, #1540) - fix(cli/mcp): fall back to JSON when GCF encoding fails (#1518, #1539) Co-authored-by: Claude Fable 5 <[email protected]>
Shashankss1205
added
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows the scoped behavior described in #1518. Successful GCF output and the missing-package fallback remain unchanged.
Validation
PYTHONPATH=src PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest tests/unit/tools/test_gcf_encoder.py -q(8 passed, 2 skipped becausegcf-pythonis not installed)python -m compileall -q src tests/unit/tools/test_gcf_encoder.pygit diff --checkThe default local pytest plugin set has an unrelated
pytest-recording/pytest-vcrconflict, so the focused test was rerun with third-party plugin autoload disabled.Closes #1518