Skip to content

fix(falkordb): isolate embedded contexts by port - #1436

Merged
Shashankss1205 merged 1 commit into
CodeGraphContext:mainfrom
lntutor:fix/falkordb-port-collisions-1387
Jul 31, 2026
Merged

Shashankss1205 merged 1 commit into
CodeGraphContext:mainfrom
lntutor:fix/falkordb-port-collisions-1387

Conversation

@lntutor

@lntutor lntutor commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • derive a stable embedded FalkorDB port from each context’s Unix socket path
  • forward that port from the manager to its worker
  • preserve explicit FALKORDB_PORT overrides
  • expose the optional port setting in the configuration reference
  • add regression coverage for port selection and worker environment propagation

Fixes #1387

Tests

  • PYTHONPATH=src .venv/bin/pytest tests/unit/core/test_falkordb_port_selection.py tests/unit/core/test_database_falkordb_wrapper.py tests/unit/core/test_database_falkordb_remote.py tests/unit/tools/test_falkordb_kuzu_session_kwargs.py tests/unit/tools/test_falkordb_schema_and_watcher_fixes.py tests/unit/cli/test_model_defaults.py tests/unit/cli/test_bug001_config_override.py -q
  • .venv/bin/ruff check tests/unit/core/test_falkordb_port_selection.py
  • git diff --check

Note: full Ruff checks on modified source modules report existing unrelated violations.

@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the shashankss1205's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Shashankss1205 Shashankss1205 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff and verified locally: merged onto current main and ran the relevant test suite — all green.

@Shashankss1205
Shashankss1205 merged commit 282ab0d into CodeGraphContext:main Jul 31, 2026
1 check failed
@Shashankss1205

Copy link
Copy Markdown
Collaborator

Thanks @lntutor for this contribution — merged! 🎉

Really appreciate you taking the time to work on CodeGraphContext. We'd love to have you contribute back again — feel free to pick up another open issue or share ideas in the discussions. Happy hacking!

@github-project-automation github-project-automation Bot moved this from Backlog tasks to Done in CGC Progress Board Jul 31, 2026
@Shashankss1205 Shashankss1205 added gssoc:approved GSSoC validation: counts toward scoring level:advanced GSSoC difficulty: 55 pts contributor / 30 mentor mentor:Shashankss1205 GSSoC mentor attribution: credits reviewing mentor quality:clean GSSoC quality: x1.2 contributor / +5 mentor type:bug GSSoC type bonus: bug labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC validation: counts toward scoring level:advanced GSSoC difficulty: 55 pts contributor / 30 mentor mentor:Shashankss1205 GSSoC mentor attribution: credits reviewing mentor quality:clean GSSoC quality: x1.2 contributor / +5 mentor type:bug GSSoC type bonus: bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug(graph): Port collision silently redirects indexing into a different, empty database

2 participants