Repository navigation
Graceful cancel fix - #137
Conversation
|
@sreeja-code-dev is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
there is a little conflict in the code I am working on . I will raise the pull request again after resolving . |
|
Last commit attempted with the updated python file is final change. |
|
Hey, can you add an image illustrating this change? I am quite unsure if it solves the actual issue discussed. |
|
Alright I will be adding an image illustration. |
|
|
|
The logic to address this deletion bug is now implemented in the 'build_graph_from_path_async'function's exception handler. Here's the dedicated check: if "no such file found" in error_message or "deleted" in error_message or "not found" in error_message:
status=JobStatus.CANCELLED
else:
status=JobStatus.FAILEDThis ensures that if the source files are removed during the graph building process, the job manager correctly marks the job as "CANCELLED", providing accurate status tracking rather than a generic 'FAILED' status. |
|
Hey, I am not talking of the visual explanation. We already are in production, can you test it out on a code editor and see if the results as expected? You can check out the demo video to see how to install the tool. |
|
Alright on it. |
|
|
|
Worked with dummy data and the async def function worked properly with the changes made to the exception handling part. |
|
|
|
|
|
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 20788152 | Triggered | Neo4j Credentials | 2fcb1f8 | tests/conftest.py | View secret |
| 21343765 | Triggered | Generic Password | 2fcb1f8 | tests/sample_project/edge_cases/hardcoded_secrets.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…-cancel-fix Graceful cancel fix
…-cancel-fix Graceful cancel fix
2 participants
Fixes #13 — Ensures that if a repo is deleted during indexing, the job is gracefully cancelled instead of failing abruptly.
1)Checks error message for deletion indicators ("no such file", "deleted", "not found")
2)Updates job status to CANCELLED if deletion is detected
3)Preserves error logs for transparency and debugging
Labels: Hacktoberfest25 bug good first issue