Skip to content

chore(parsers): minor leftovers from the #1538 audit — annotation line convention, Ruby class/global vars, Ruby variable values #1660

Closed

Description

@Shashankss1205

The 'Minor' section of #1538, split out so the parent audit can close. Each is small and independent; the substantive sections all landed (#1628, #1654, #1657, #1659).

  1. kotlin.py:1223/:1342, php.py:280/:213 — line_number points at the annotation/attribute line rather than the declaration. python.py handles this deliberately via decorated_definition and csharp.py was aligned in fix(parsers): final #1538 audit batch — spurious records, PHP enums, C macros/enum members #1659 — Kotlin and PHP should follow the same declaration-line convention.
  2. ruby.py:38-47, :516-522 — @@class_vars and $globals are never captured (the variables query only matches plain/instance assignments).
  3. ruby.py:487-507 — variable value is always None: node.parent returns a fresh Python wrapper each access, so id(current) differs for the same underlying node and the @name/@value captures land in different buckets (n1 == n2 is True while id(n1) == id(n2) is False — bucket by (start_byte, end_byte) instead).

(The C/C++ macro end_line off-by-one from the same list was fixed in #1628/#1659.)

Activity

  1. github-actions commented on Aug 19, 2026

    @github-actions
    Contributor

    Hi! 👋 Join our CodeGraphContext Discord channel to collaborate: https://discord.gg/dR4QY32uYQ

  2. moved this from Backlog tasks to In progress in CGC Progress Boardon Aug 26, 2026
  3. added a commit that references this issue on Aug 26, 2026
  4. moved this from In progress to Done in CGC Progress Boardon Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions