Repository navigation
Read the BOM and use it to set encoding when processing files - #14
Merged
Merged
Conversation
…read its content using the detected encoding.
ericdc1
added a commit
that referenced
this pull request
Feb 10, 2016
Read the BOM and use it to set encoding when processing files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AliaSQL was having encoding problems when processing files with Spanish characters even though the BOM was set to UTF8. This was fixed by reading the BOM for the files and use the detected encoding as input to the StreamReader(...).
Tested locally by executing AliaSQL with files containing Spanish characters, which were read into a web UI and displayed correctly. It has been verified that the solution builds but I have not executed all the tests in the solution.